1.18 - Fix getSelected() stale results #5757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more wasteful, but is identical to 1.17 behaviour and avoids the possibility of stale selection data in case the zone has not been rerendered after a selection chnage.
cwisniew
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Fixes #5745
Description of the Change
Changes
ZoneViewModel#getSelectedTokenList()to behave like 1.17'sZoneRenderer#getSelectedTokensList(), which resolves theTokenobjects on demand rather than caching it somewhere.This fixes the issue since a render is not required for
getSelected()to be updated.Possible Drawbacks
Slight reduction in
getSelected()performance and similar, and corresponding increase in memory allocation.Documentation Notes
N/A
Release Notes
getSelected()would have out-of-date results when called fromonChangeSelectionThis change is