Fix get macro location #5653
Merged
Fix get macro location #5653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwvanderlinde
approved these changes
Jun 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
resolves #5638
Description of the Change
The
getMacroLocation()method was exposing the internal workings of how the parser tracked context, so when these changed, it caused an error with the return value in some instances. I have added a newgetCallableLocation()method to the parser macro source location that exposes these values in a way compatible withgetMacroLocation(), while allowing the context handling in the parser to remain hidden from macros.Possible Drawbacks
Before the change in 1.18
getMacroLocation()would not produce consistent values for token macros. I have remedied this by returning a consistent value that matches the documented behaviour on the wiki. This may break some macros, but it's unlikely, and probably better than trying to emulate the broken behaviour for an edge case for this macro call.Documentation Notes
Fix for bug in
getMacroLocation()that was introduced with the changes to macro function call routing.Release Notes
This change is