PR with fixes for issue #97 and issue #98 and version bump #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See issue #97 and issue #98 For CLI mode, Controller was never started up and so Cli-originated requests would fail with "invalid command" due to connection refused to non-existent RPC server. Now CLI is optionally started after main start. CLI's "quit" command terminates both CLI mode AND causes the entire process to shutdown. A couple of if-condition logic errors in ConnectionCreator meant that it wouldn't quickly shutdown after ConnectionCreator.halt() was called. In addition there was no shortcut exit in ConnectionAcceptor so this has been added. Lack of quick shutdown means either class would attempt to check peers against blacklist, which in turn would mean MapDB access AFTER DB shutdown, which is a known cause of DB corruption.
Being able to view new peer version, and with more DEBUG-level logging to Synchronizer, should help track down any remaining peer/synchronization issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.