more work on synchronization #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During synchronization, receiving peer rolls back to last common block and then requests block from sending peer. However if sending peer is on a fork then block heights will differ causing confusion. Now we reject synchronization from peers with conflicting block heights, letting network consensus decide the valid fork. Also, don't send bulk block signatures if we're synchronzing ourselves as there's a small chance we might try to send a block we're just about to roll back.
Revived previously disabled peer blacklisting. Peers are blacklisted if something causes an exception during synchronization. Blacklisting expires after 1 day.
Peers can be manually blacklisted via API using POST /peers/blacklist {IPaddress}
All peers can be de-blacklisted using the existing DELETE /peers API call
During synchronization, fixed peer's block height checking by using forked-DB's block height, not main DB's block height. Also sleep 5 seconds between chunks of 500 blocks to reduce network load.
Fixed peer buildtime messages. Timestamp was constructed incorrectly in Controller to start with, and parsed incorrectly in VersionMessage.
In networking, don't even try to connect to our own IP address or accept connections from our own IP address.
See Network.isHostLocalAddress()
Reduced logging output at INFO level by bumping some log entries down to DEBUG or even TRACE.
Some more code tidying.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.