Skip to content

Fix #239 #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 8, 2024
Merged

Fix #239 #240

merged 2 commits into from
Nov 8, 2024

Conversation

mdosch
Copy link
Contributor

@mdosch mdosch commented Nov 7, 2024

Fixes #239

@rykov
Copy link

rykov commented Nov 8, 2024

I've encountered this too, and changes to .Encode seem to have been made by mistake. I second this PR to undo this backward incompatible change without a major version change.

lubux
lubux approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@lubux lubux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for providing a fix as well! :)

@lubux lubux merged commit f8b3f21 into ProtonMail:main Nov 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lubux lubux lubux approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Encode and EncodeWithHeader look the same

3 participants

@mdosch @rykov @lubux