Skip to content

Fix: Calculation error for quotas #1400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: Calculation error for quotas #1400

wants to merge 1 commit into from
+6 −2

Conversation

luohua13
Copy link

What type of PR is this?

/kind bug

What this PR does / why we need it:

  1. Remove usage of quotas when pod is terminated status.
    When setting replicas from 1 to 0, the scheduler got update event first and run s.podManager.DelPod(pod), then the deletion event to fail to remove usage normally.

  2. Delete quotas when clear the hard quota of Resourceqota(not deleted the cr resource).

@luohua13
Fix: Remove usage of quotas when pod is terminated and delete quota w…
c354161 
…hen clear resourcequota(not deleted)

Signed-off-by: luohua13 <[email protected]>
@hami-robot hami-robot bot added kind/bug Something isn't working dco-signoff: yes labels Oct 11, 2025
@hami-robot
Copy link
Contributor

hami-robot bot commented Oct 11, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: luohua13
Once this PR has been reviewed and has the lgtm label, please assign wawa0210 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hami-robot
Copy link
Contributor

hami-robot bot commented Oct 11, 2025

Welcome @luohua13! It looks like this is your first PR to Project-HAMi/HAMi 🎉

@gemini-code-assist Gemini Code Assist
Copy link
Contributor

Summary of Changes

Hello @luohua13, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses two distinct but related bugs concerning quota calculation and management within the scheduler. It ensures that resource quotas are accurately released when pods enter a terminated state and correctly updated when a ResourceQuota object's hard limits are modified, thereby improving the reliability of resource allocation and preventing potential resource exhaustion issues due to stale or incorrect quota usage.

Highlights

  • Pod Termination Quota Release: Modified the onAddPod function to ensure that quota usage is explicitly removed for pods detected in a terminated state before they are deleted from the pod manager. This prevents resource leaks when pods are scaled down or terminated, addressing a scenario where deletion events might fail to remove usage normally.
  • Quota Update Handling Correction: Corrected the onUpdateQuota function to use the oldObj when calling onDelQuota. This ensures that when a quota is updated (e.g., its hard limits are cleared), the previous quota's resources are properly released before the new quota configuration is applied, preventing incorrect quota accounting.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@hami-robot hami-robot bot added the size/XS label Oct 11, 2025
gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 11, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes two bugs related to quota calculation. The first fix ensures quota usage is removed for terminated pods, preventing resource leaks due to race conditions between update and delete events. The second fix correctly updates quota limits when a ResourceQuota object is modified. The changes are logical and well-implemented. I have one suggestion for improving the robustness of a related function.

@codecov Codecov
Copy link

codecov bot commented Oct 11, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/scheduler/scheduler.go 0.00% 6 Missing ⚠️
Flag Coverage Δ
unittests 63.05% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/scheduler/scheduler.go 47.66% <0.00%> (-0.34%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lengrongfu lengrongfu Awaiting requested review from lengrongfu

@ouyangluwei163 ouyangluwei163 Awaiting requested review from ouyangluwei163

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

dco-signoff: yes kind/bug Something isn't working size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@luohua13