Skip to content

fix: Before executing MIG partitioning, suppress NVML usage in o… #1095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2025
Merged

fix: Before executing MIG partitioning, suppress NVML usage in o… #1095

merged 1 commit into from
Jun 13, 2025

Conversation

Goend
Copy link
Contributor

@Goend Goend commented May 29, 2025

…ther goroutines. (#1088)

What type of PR is this?
/kind bug

What this PR does / why we need it:
Before executing MIG partitioning, suppress NVML usage in other goroutines.

Which issue(s) this PR fixes:
Fixes #1088

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@codecov Codecov
Copy link

codecov bot commented May 29, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
unittests 63.20% <ø> (+2.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Goend Goend changed the title [WIP]fix: Before executing MIG partitioning, suppress NVML usage in o… fix: Before executing MIG partitioning, suppress NVML usage in o… Jun 3, 2025
@github-actions github-actions bot added the kind/bug Something isn't working label Jun 3, 2025
@Goend
Copy link
Contributor Author

Goend commented Jun 3, 2025

@archlitchi need review

@archlitchi
Copy link
Member

have you tested on your local environment?

@Goend
Copy link
Contributor Author

Goend commented Jun 3, 2025

have you tested on your local environment?

yes

@archlitchi
Copy link
Member

great!, i'll try it on my local environment

@archlitchi
Copy link
Member

CC @ouyangluwei163

@hami-robott hami robott
Copy link
Contributor

hami-robott bot commented Jun 4, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Goend
Once this PR has been reviewed and has the lgtm label, please assign wawa0210 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hami-robott hami-robott bot added the size/L label Jun 4, 2025
@hami-robott hami-robott bot added size/XL and removed size/L labels Jun 4, 2025
@Goend
Copy link
Contributor Author

Goend commented Jun 5, 2025 •
edited
Loading

@ouyangluwei163 If you have time, I hope you can help conduct an overall review to expedite moving this patch into the branch and help stabilize the main branch's MIG partitioning,thanks a lot.

@ouyangluwei163
Copy link
Contributor

@ouyangluwei163 If you have time, I hope you can help conduct an overall review to expedite moving this patch into the branch and help stabilize the main branch's MIG partitioning,thanks a lot.

Ok, this week is a bit busy, I will test it next week.

@Goend
Copy link
Contributor Author

Goend commented Jun 9, 2025

great!,thanks @ouyangluwei163

@Goend
Copy link
Contributor Author

Goend commented Jun 11, 2025

@ouyangluwei163 Since I will no longer have access to the test environment next week, it may be necessary to conduct a code review beforehand so that I can handle the related code changes.

@ouyangluwei163
Copy link
Contributor

@ouyangluwei163 Since I will no longer have access to the test environment next week, it may be necessary to conduct a code review beforehand so that I can handle the related code changes.

OK, I have started today.

@ouyangluwei163 ouyangluwei163 mentioned this pull request Jun 11, 2025
Closed
@ouyangluwei163
Copy link
Contributor

/lgtm

@hami-robott hami-robott bot added the lgtm label Jun 12, 2025
@archlitchi
Copy link
Member

/lgtm

@archlitchi archlitchi merged commit 3cb2de8 into Project-HAMi:master Jun 13, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Shouren Shouren Shouren left review comments

Assignees

@archlitchi archlitchi

@ouyangluwei163 ouyangluwei163

Labels

dco-signoff: yes kind/bug Something isn't working lgtm size/XL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Mig apply error show nvidia-mig-parted failed with code

4 participants

@Goend @archlitchi @ouyangluwei163 @Shouren