Fix error when using prefect work-queue ls without enabling work pools
#8427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prefect-orion ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
desertaxle
approved these changes
Feb 6, 2023
Member
desertaxle
left a comment
There was a problem hiding this comment.
LGTM!
I don't think the double default will be a large issue since users won't have the ability to create another work pool unless they choose to toggle on the experimental flag.
zanieb
reviewed
Feb 6, 2023
src/prefect/cli/work_queue.py
Outdated
| View all work queues. | ||
| """ | ||
| if not pool: | ||
| if not pool and PREFECT_EXPERIMENTAL_ENABLE_WORK_POOLS.value() is False: |
Contributor
There was a problem hiding this comment.
You should use the experiment_enabled helper.
zanieb
reviewed
Feb 6, 2023
Comment on lines
+370
to
+375
| table = Table( | ||
| title="Work Queues", | ||
| caption="(**) denotes a paused queue", | ||
| caption_style="red", | ||
| ) | ||
| table.add_column("Name", style="green", no_wrap=True) |
Contributor
There was a problem hiding this comment.
Is all that follows here just a replication of some old code that was deleted before it should have been ?
ddelange
added a commit
to ddelange/prefect
that referenced
this pull request
Feb 9, 2023
* 'main' of https://github.com/prefecthq/prefect: (26 commits) Update Infrastructure to include extra-pip-package in example and updated deployment.yaml (PrefectHQ#8465) Fix `prefect dev start` (PrefectHQ#8176) Bump @prefecthq/orion-design from 1.2.21 to 1.2.22 in /orion-ui (PrefectHQ#8456) Update flowRunFilter on WorkPool page (PrefectHQ#8453) Restore Prefect wrapper that shows details on HTTP errors (PrefectHQ#8391) Use the len of the JSON representation when determining log size (PrefectHQ#8449) Dezombify concurrency limits (PrefectHQ#8408) Bump @prefecthq/orion-design from 1.2.19 to 1.2.21 in /orion-ui (PrefectHQ#8452) Removes experimental guards around work pools (PrefectHQ#8362) Update return type for get_run_logger (PrefectHQ#8422) Add utilities for deprecation (PrefectHQ#8402) Add ability to create a new flow run from the UI with custom default parameter values taken from a previous run (PrefectHQ#8405) Enhancement: Increase polling interval on flow runs to match logs (PrefectHQ#8441) During blocks registration, hide link to blocks catalog if PREFECT_UI_URL is None (PrefectHQ#8438) Add Orion info route (PrefectHQ#8400) Bump @prefecthq/orion-design from 1.2.18 to 1.2.19 in /orion-ui (PrefectHQ#8436) Add generic webhook block (PrefectHQ#8401) Update Queue name to Work Queue (PrefectHQ#8424) Fix error when using `prefect work-queue ls` without enabling work pools (PrefectHQ#8427) Add release notes for 2.7.12 (PrefectHQ#8429) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8426
The
prefect work-queue lscommand was using a route to lookup work pools associated with with each of the work queues. This doesn't work without enabling a flag. This wasn't caught by my tests because I was using a fixture that auto-enabled the flag. This is no longer the case.Updated video of the changes:
https://www.loom.com/share/c697692aa93e4c2f90c185f23e160fed
Note, it shows two default queues because I have a default-agent-pool and a separate pool with a default queue. I could see this potentially causing confusion.
Example
Checklist
<link to issue>"fix,feature,enhancement