fix mcp wrapping #1143
Merged
fix mcp wrapping #1143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses modifications related to MCP tool wrapping and testing. It updates the MCP tool validation in tests to focus on the call structure and removes the legacy MCP tool discovery logic from the agent code.
- Updated tests in tests/ai/test_mcp.py to verify that tool call messages have valid IDs and arguments.
- Removed the unused MCP tool discovery logic from src/marvin/agents/agent.py.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/ai/test_mcp.py | Modified test assertions to focus on tool call structure. |
| src/marvin/agents/agent.py | Removed MCP tool discovery; active_mcp_servers parameter remains unused. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1142