Skip to content

Update Webhook notification #5308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mariusandra merged 1 commit into from
Jul 23, 2021
Merged

Update Webhook notification #5308

mariusandra merged 1 commit into from
Jul 23, 2021

Conversation

@neilkakkar
Copy link
Contributor

@neilkakkar neilkakkar commented Jul 23, 2021

Changes

Fixes #5260

Updates webhook notification copy

image

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests
  • Migrations are safe to run at scale (e.g. PostHog Cloud) – present proof if not obvious
  • New/changed UI is decent on smartphones (viewport width around 360px)

@neilkakkar neilkakkar requested a review from mariusandra July 23, 2021 10:39
@timgl timgl temporarily deployed to posthog-pr-5308 July 23, 2021 10:41 Inactive
@mariusandra mariusandra enabled auto-merge (squash) July 23, 2021 10:43
@mariusandra mariusandra merged commit 2b3eb62 into master Jul 23, 2021
@mariusandra mariusandra deleted the webhook-fix-notif branch July 23, 2021 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mariusandra mariusandra mariusandra approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BUG: Notification says Slack, while update was regarding Discord.

4 participants

@neilkakkar @mariusandra @timgl