fix(new-tab): add persons/cohorts #38058
Merged
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+114
to
+122
| const products = [...getDefaultTreeProducts(), ...getDefaultTreePersons()] | ||
| .map((fs) => ({ | ||
| href: fs.href, | ||
| name: fs.path, | ||
| icon: getIconForFileSystemItem(fs), | ||
| flag: fs.flag, | ||
| })) | ||
| .filter(({ flag }) => !flag || featureFlags[flag as keyof typeof featureFlags]) | ||
| .toSorted((a, b) => a.name.localeCompare(b.name)) |
There was a problem hiding this comment.
syntax: inconsistent property definitions in cohorts data
In the getDefaultTreePersons function, the Cohorts object uses type: 'cohort' while the Persons object uses iconType: 'person'. This inconsistency could cause issues with icon rendering.
Suggested change
| const products = [...getDefaultTreeProducts(), ...getDefaultTreePersons()] | |
| .map((fs) => ({ | |
| href: fs.href, | |
| name: fs.path, | |
| icon: getIconForFileSystemItem(fs), | |
| flag: fs.flag, | |
| })) | |
| .filter(({ flag }) => !flag || featureFlags[flag as keyof typeof featureFlags]) | |
| .toSorted((a, b) => a.name.localeCompare(b.name)) | |
| const products = [...getDefaultTreeProducts(), ...getDefaultTreePersons()] | |
| .map((fs) => ({ | |
| href: fs.href, | |
| name: fs.path, | |
| icon: getIconForFileSystemItem(fs), | |
| flag: fs.flag, | |
| })) | |
| .filter(({ flag }) => !flag || featureFlags[flag as keyof typeof featureFlags]) | |
| .toSorted((a, b) => a.name.localeCompare(b.name)) |
Context Used: Context - When using HogQL, ensure that property definitions are explicitly typed to avoid errors related to type strictness. (link)
|
Size Change: 0 B Total Size: 2.73 MB ℹ️ View Unchanged
|
adamleithp
approved these changes
Sep 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The persons and cohorts pages were missing on the new tab page.
Changes
I kept it as "Persons" for now, as that's the name of the menu entry, however we probably should talk if we want to rename it.
How did you test this code?
👀