feat(insights): add modal asking if user wants to use/discard overrides when editing insight #38016
+129
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+42
to
+43
| // we whould always have a short_id when overrides are present | ||
| if (insight.short_id) { |
There was a problem hiding this comment.
syntax: Typo: "whould" should be "would"
Suggested change
| // we whould always have a short_id when overrides are present | |
| if (insight.short_id) { | |
| // we would always have a short_id when overrides are present |
Comment on lines
+65
to
+66
| // we whould always have a short_id when overrides are present | ||
| if (insight.short_id) { |
There was a problem hiding this comment.
syntax: Typo: "whould" should be "would"
Suggested change
| // we whould always have a short_id when overrides are present | |
| if (insight.short_id) { | |
| // we would always have a short_id when overrides are present |
Comment on lines
+45
to
+55
| // :FIXME: This should work, but doesn't due to a race condition in insightsSceneLogic. | ||
| // What I _think_ is happening roughly: urlToAction gets called with the query, and calls updateQuery. | ||
| // Then setSceneState gets executed and calls the reloadInsightLogic listener. This then calls loadInsight, | ||
| // but the overrides are empty as the url doesn't have them any more. Now the query doesn't have the overrides as | ||
| // well. | ||
| urls.insightEdit( | ||
| insight.short_id, | ||
| currentLocation.searchParams.dashboard, | ||
| query | ||
| ) | ||
| ) |
There was a problem hiding this comment.
logic: The FIXME comment indicates this code has a known race condition that prevents it from working correctly. This breaks the core functionality of editing with overrides.
|
Size Change: +129 B (0%) Total Size: 2.73 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated4 snapshot changes in total. 0 added, 4 modified, 0 deleted:
Triggered by this commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
https://posthog.slack.com/archives/C0368RPHLQH/p1756732974736689
Changes
This adds a modal asking the user wether they want to use or discard the overrides when editing an insight.
FIXME: Unfortuntately I haven't yet been able to get this working with the various layouts/states that insights can be in right now. See the comment in code. I hope it will be easier fixing it once the layout changes are through, and then we can revisit this.
How did you test this code?
👉 Stay up-to-date with PostHog coding conventions for a smoother review.