Skip to content

fix(web-analytics): connect data logics to scene logic #38008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix(web-analytics): connect data logics to scene logic #38008

wants to merge 5 commits into from
+261 −85

Conversation

mariusandra
Copy link
Collaborator

Problem

The web analytics tab would reload every time it was opened.

Changes

Attach the various dataNodeLogics to the scene's logic.

How did you test this code?

Clicked between the tabs, saw the count of queries to /query go from a dozen to just one. Still a bit of work to do to remove that last one.

@posthog-bot posthog-bot requested review from a team and rafaeelaudibert and removed request for a team September 12, 2025 10:59
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 12, 2025 •
edited
Loading

Size Change: 0 B

Total Size: 2.73 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 2.73 MB

compressed-size-action

greptile-apps[bot]
greptile-apps bot reviewed Sep 12, 2025
View reviewed changes
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

23 files reviewed, no comments

Edit Code Review Bot Settings | Greptile

adamleithp
adamleithp approved these changes Sep 12, 2025
View reviewed changes
Copy link
Contributor

@adamleithp adamleithp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ts error, but :check:

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 8)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 8)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

rafaeelaudibert
rafaeelaudibert approved these changes Sep 12, 2025
View reviewed changes
Copy link
Member

@rafaeelaudibert rafaeelaudibert left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, it works, but I don't really understand why. I'd love a brownbag (or just a short video) going over the reasons why this works/is needed

I'll also do a follow-up PR simplifying that LogicWrapper | BuiltLogic type

@mariusandra
Copy link
Collaborator Author

The tldr is:

  • Each scene exports a logic in the SceneExport object
  • That logic is then held onto whenever you switch tabs. it'll remain active in the background.
  • If you have ad-hoc logics on the frontend that mount with a component, they will be unmounted when the react component unmounts
  • Most notably, all dataNodeLogics will be cleared and it'll refresh all the data.
  • This PR adds useAttachedLogic(myAdHocLogic, mySceneLogic) calls, which tie the ad-hoc logics to the scene logic.
  • Now if you switch tabs, none of those attached logics are unmounted, and when you come back, the data is all still there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamleithp adamleithp adamleithp approved these changes

@robbie-c robbie-c robbie-c approved these changes

@rafaeelaudibert rafaeelaudibert rafaeelaudibert approved these changes

+1 more reviewer

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mariusandra @posthog-bot @adamleithp @robbie-c @rafaeelaudibert