fix: no billing api calls in selfhosted #37834
Open
+30
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +95 B (0%) Total Size: 2.73 MB ℹ️ View Unchanged
|
pauldambra
commented
Sep 10, 2025
| @@ -97,7 +105,7 @@ export const billingSpendLogic = kea<billingSpendLogicType>([ | |||
| null as BillingSpendResponse | null, | |||
| { | |||
| loadBillingSpend: async () => { | |||
| if (!canAccessBilling(values.currentOrganization)) { | |||
| if (!canAccessBilling(values.currentOrganization) || !values.isCloudOrDev) { | |||
There was a problem hiding this comment.
Should we check against isCloud rather than isCloudOrDev? I wouldn't want to obscure that this won't trigger locally in dev.
(Though I might have wrong assumptions about the definitions of cloud/dev in this context)
i think this means in posthog cloud, or in local development on an engineer machine, and otherwise not
i guess then maybe i should invert this and be more clear so there's a !isSelfHosted so we don't have to keep adding conditions like isCI 🤔
pauldambra
commented
Sep 13, 2025
| @@ -3578,8 +3578,10 @@ export interface PreflightStatus { | |||
| client_id?: string | |||
| } | |||
| } | |||
| /** Whether PostHog is running in DEBUG mode. */ | |||
| /** Whether PostHog is running in settings.DEBUG or settings.E2E_TESTING. */ | |||
There was a problem hiding this comment.
slightly weird that debug includes E2E_TESTING, but let's maintain that since it already exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on self hosted installs as I click around I may trigger some code that hits the various billing logics. they check if i'm an admin or higher and i am, so they try and call billing APIs, and then show an error toast.
but there's nothing I can do about it
so, let's just not?