Skip to content

Fix tp model load #10739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2025
Merged

Fix tp model load #10739

merged 1 commit into from
Jun 17, 2025

Conversation

DesmonDay
Copy link
Contributor

Before submitting

  • Lint code. If there are lint issues, please format the code first.
# Install and register `pre-commit` in the project folder
pip install pre-commit && pre-commit install

# Process previous code files separately
pre-commit run --file XXXX.py
  • Add test cases into tests folder. If there are codecov issues, please add tests cases first.

PR types

Bug fixes

PR changes

Others

Description

修复TP加载内存暴涨问题。

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Jun 16, 2025

Thanks for your contribution!

@codecov Codecov
Copy link

codecov bot commented Jun 16, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.87%. Comparing base (98b08b1) to head (6e51175).
⚠️ Report is 80 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/transformers/model_utils.py 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #10739      +/-   ##
===========================================
- Coverage    46.88%   46.87%   -0.01%     
===========================================
  Files          800      800              
  Lines       132785   132787       +2     
===========================================
- Hits         62254    62246       -8     
- Misses       70531    70541      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

lugimzzz
lugimzzz approved these changes Jun 17, 2025
View reviewed changes
Copy link
Contributor

@lugimzzz lugimzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

nepeplwu
nepeplwu approved these changes Jun 17, 2025
View reviewed changes
Copy link

@nepeplwu nepeplwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nepeplwu nepeplwu merged commit 141499b into PaddlePaddle:develop Jun 17, 2025
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lugimzzz lugimzzz lugimzzz approved these changes

+1 more reviewer

@nepeplwu nepeplwu nepeplwu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DesmonDay @nepeplwu @lugimzzz