Skip to content

Add config replace_with_c_embedding #9638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ZHUI merged 9 commits into from
Dec 18, 2024
Merged

Add config replace_with_c_embedding #9638

ZHUI merged 9 commits into from
Dec 18, 2024

Conversation

@Xing-lil
Copy link
Contributor

@Xing-lil Xing-lil commented Dec 16, 2024 •
edited
Loading

PR types

Others

PR changes

Others

Description

Add replace_with_c_embedding in tensor_parallel_config, and add test.
Enable the pass by setting tensor_parallel_config to replace_with_c_embedding in YAML.
eg. tensor_parallel_config: replace_with_c_embedding

@paddle-bot
Copy link

paddle-bot bot commented Dec 16, 2024

Thanks for your contribution!

@codecov
Copy link

codecov bot commented Dec 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 52.74%. Comparing base (da7a7d2) to head (33eed1c).
Report is 266 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/trainer/training_args.py 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #9638      +/-   ##
===========================================
- Coverage    52.81%   52.74%   -0.07%     
===========================================
  Files          710      711       +1     
  Lines       111238   111485     +247     
===========================================
+ Hits         58749    58808      +59     
- Misses       52489    52677     +188

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ZHUI
ZHUI approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 确保这个选项不会影响普通动态图。

liym27
liym27 approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@liym27 liym27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZHUI ZHUI merged commit 0470466 into PaddlePaddle:develop Dec 18, 2024
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZHUI ZHUI ZHUI approved these changes

+1 more reviewer

@liym27 liym27 liym27 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Xing-lil @ZHUI @liym27