Skip to content

Conversation

DesmonDay
Copy link
Contributor

PR types

Bug fixes

PR changes

Others

Description

Situation of empty state_dict will happen when using split_param.

Copy link

paddle-bot bot commented Nov 6, 2024

Thanks for your contribution!

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 53.00%. Comparing base (2f0b407) to head (16857c1).
Report is 1 commits behind head on develop.

Current head 16857c1 differs from pull request most recent head 7800852

Please upload reports for the commit 7800852 to get more accurate results.

Files with missing lines Patch % Lines
...dlenlp/trainer/unified_checkpoint/async_handler.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9380      +/-   ##
===========================================
- Coverage    53.01%   53.00%   -0.01%     
===========================================
  Files          674      674              
  Lines       107420   107424       +4     
===========================================
  Hits         56945    56945              
- Misses       50475    50479       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit d526be2 into PaddlePaddle:develop Nov 7, 2024
9 of 12 checks passed
DesmonDay added a commit to DesmonDay/PaddleNLP that referenced this pull request Nov 7, 2024
* fix empty state_dict

* update sharding split_parma
DesmonDay added a commit that referenced this pull request Nov 7, 2024
* [Unified Checkpoint] Support empty state_dict saving (#9380)

* fix empty state_dict

* refine dtype use (#9366)

---------

Co-authored-by: wanghuancoder <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants