Skip to content

Conversation

@FeixLiu
Copy link
Contributor

@FeixLiu FeixLiu commented Jul 8, 2024

PR types

Bug fixes

PR changes

Others

Description

fix distributed allgather bug

@paddle-bot
Copy link

paddle-bot bot commented Jul 8, 2024

Thanks for your contribution!

@codecov
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 55.73%. Comparing base (bdd2287) to head (e5eeaa0).
Report is 214 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/utils/distributed.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8730   +/-   ##
========================================
  Coverage    55.73%   55.73%           
========================================
  Files          623      623           
  Lines        97464    97464           
========================================
  Hits         54324    54324           
  Misses       43140    43140           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit 595c2fb into PaddlePaddle:develop Jul 9, 2024
FeixLiu added a commit to FeixLiu/PaddleNLP that referenced this pull request Jul 26, 2024
gongel pushed a commit that referenced this pull request Jul 31, 2024
* xpu use allgather (#8697)

* xpu use allgather

* xpu use allgather

* fix xpu gather for unified ckpt (#8710)

* bug fix (#8730)

* [XPU] use allgather and fp32 multinomial for XPU (#8787)

---------

Co-authored-by: houj04 <[email protected]>
@FeixLiu FeixLiu deleted the fix_all_gather_bug branch November 27, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants