fix asynchronize save #6624
Merged
fix asynchronize save #6624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
ZHUI
reviewed
Aug 7, 2023
|
|
||
| optimizer_name = _add_variant(OPTIMIZER_NAME, self.args.optimizer_name_suffix) | ||
|
|
||
| if self.args.use_hybrid_parallel: |
There was a problem hiding this comment.
optimizer保存结束会写入一个saved_signal用来判断文件是否checkpoint完整性。挪这个位置是为了保证异步写和同步写的代码执行一致性。
| task.join() | ||
|
|
||
|
|
||
| def async_save_optimizer(optimizer_state_dict, path, saved_signal_path, protocol=4, sync_other_task=False): |
There was a problem hiding this comment.
这些东西能找个 单独的文件放一下 最好了。比如 trainer/plugins 目录
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Description
fix async save for optimizer