BugFix: GPTChineseTokenizer.get_vocab() not implemented #5736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Codecov Report
@@ Coverage Diff @@
## develop #5736 +/- ##
===========================================
- Coverage 61.70% 61.69% -0.01%
===========================================
Files 487 487
Lines 68285 68290 +5
===========================================
+ Hits 42133 42134 +1
- Misses 26152 26156 +4
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
wj-Mcat
reviewed
Apr 20, 2023
Contributor
There was a problem hiding this comment.
非常感谢解决修复此问题，不过这里还需要考虑：added_tokens_encoder，建议调整为以下代码：
Suggested change
| return {self.sp.IdToPiece(i): i for i in range(0, self.sp.GetPieceSize())} | |
| return dict({self.sp.IdToPiece(i): i for i in range(0, self.sp.GetPieceSize())}, **self.added_tokens_encoder) |
具体可参考：
PaddleNLP/paddlenlp/transformers/bert/tokenizer.py
Lines 452 to 453 in 7d48f0e
Raising NotImplementedError exception when calling GPTChineseTokenizer.get_vocab().
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
APIs
Description
Fix the bug that raises a NotImplementedError exception when calling GPTChineseTokenizer.get_vocab().