Skip to content

fix: MLFlowLogger artifact_path #21204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: release/stable
Choose a base branch
from
Open

fix: MLFlowLogger artifact_path #21204

wants to merge 2 commits into from

Conversation

yxtay
Copy link
Contributor

@yxtay yxtay commented Sep 12, 2025 •
edited
Loading

What does this PR do?

Reapplies #20669 on release/stable branch

For some reason, the PR was reverted by @Borda in f6ef409. This broke all subsequent releases since 2.5.0.post0. Please refer to the previous PR for further discussions.

Fixes #20932

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21204.org.readthedocs.build/en/21204/

@yxtay
fix: MLFlowLogger artifact_path (Lightning-AI#20669)
85c01c6 
* fix: MLFlowLogger artifact_path

* fix: use `as_posix()`
@github-actions github-actions bot added release pl Generic label for PyTorch Lightning package labels Sep 12, 2025
@SkafteNicki SkafteNicki added logger Related to the Loggers logger: mlflow labels Sep 12, 2025
@Borda Borda changed the title fix: MLFlowLogger artifact_path (#20669) fix: MLFlowLogger artifact_path Sep 12, 2025
@Borda Borda marked this pull request as draft September 12, 2025 11:38
@yxtay yxtay marked this pull request as ready for review September 12, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamFalcon williamFalcon Awaiting requested review from williamFalcon williamFalcon is a code owner

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
logger: mlflow logger Related to the Loggers pl Generic label for PyTorch Lightning package release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yxtay @SkafteNicki