-
Notifications
You must be signed in to change notification settings - Fork 3.6k
feat: add support for fsdp2 strategy in trainer #21184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: add support for fsdp2 strategy in trainer #21184
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #21184 +/- ##
========================================
- Coverage 87% 86% -1%
========================================
Files 269 271 +2
Lines 23665 24051 +386
========================================
+ Hits 20642 20710 +68
- Misses 3023 3341 +318 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably in a follow up PR:
- documentation similar to https://github.com/Lightning-AI/pytorch-lightning/blob/master/docs/source-fabric/advanced/model_parallel/fsdp.rst
- add fsdp2 to fabric?
Co-authored-by: Nicki Skafte Detlefsen <[email protected]>
for more information, see https://pre-commit.ci
I would start with FSDP2 in Fabric |
✅ This PR is Originally, I planned to follow up with:
However, per discussion with @tchaton, we’re I’ll leave this PR open so it can be easily revived later, if we decide to. |
What does this PR do?
Fixes #<issue_number>
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--21184.org.readthedocs.build/en/21184/