KGP IT: test example projects can be assembled #4368
Closed
+2,298
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While trying to add Wasm in the example I found that DGP still produced output even when the code could not be compiled. To avoid creating examples that can't be compiled, verify the examples can be compiled.
(todo close this PR and move the changes to adam/fix-classpath-without-metadata-compilations)
(todo close this PR and move the changes to adam/fix-classpath-without-metadata-compilations)
Member
Author
|
It's not possible to fix the tests without the fix from #4296, so I'll merge these changes into that PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to add Wasm in the example I found that DGP still produced output even when the code could not be compiled. To avoid creating examples that can't be compiled, verify the examples can be compiled.