Replace usages of deprecated in JDK 20 java.net.URL constructor in Gradle runner
#3435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IgnatBeresnev
approved these changes
Jan 11, 2024
vmishenev
approved these changes
Jan 15, 2024
vmishenev
pushed a commit
that referenced
this pull request
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is at least to not suggest usage of deprecated in JDK 20 API. While it's not full direct replacement (as far as I understand by reading deprecation note on URL class), this should be fine for how we use it in Gradle plugin.
I've also investigated this migration in all code base here - 521d9e5
Though, I've decided not to do this, because of some questionable changes there. In the end it will be fixed in #2993. I will add this link there to be aware of the scope of the changes.