Skip to content

fix(formula): prevent conversion error on duplicate SubNode connections #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(formula): prevent conversion error on duplicate SubNode connections #532

wants to merge 1 commit into from

Conversation

ant66376
Copy link

@ant66376 ant66376 commented Mar 17, 2025 •
edited
Loading

  • Add network depth validation when converting formulas to models
  • Throw ConversionError if input layer SubNode connects to same variable more than twice
  • Implement layer deepening strategy to resolve multi-connection issues

For equation=0.8329-100log(R)-0.01M+M^2+R+R^2

  • Before fix
    image

-After fix
image

@ant66376
fix(formula): prevent conversion error on duplicate SubNode connections
c3b4a29 
- Add network depth validation when converting formulas to models
- Throw ConversionError if input layer SubNode connects to same variable more than twice
- Implement layer deepening strategy to resolve multi-connection issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ant66376