Skip to content

Conversation

benjaminjkraft
Copy link
Contributor

Summary:

We're getting close to ready to make genqlient "maintained open-source"!
So it's time to add it here. In general I think this page needs some
reordering but I just put it in at a seemingly reasonable place to
start. The header image from its README doesn't really work well at
this size, so I just left it without a logo for now; we can add one
when someone gets a chance to make one.

I'll hold off on landing this until genqlient#96 lands.

Issue: Khan/genqlient#35

Test plan:

npm run build and view in a browser

We're getting close to ready to make genqlient "maintained open-source"!
So it's time to add it here.  In general I think this page needs some
reordering but I just put it in at a seemingly reasonable place to
start.  The header image from its README doesn't really work well at
this size, so I just left it without a logo for now; we can add one
when someone gets a chance to make one.

I'll hold off on landing this until genqlient#96 lands.

Test plan: `npm run build` and view in a browser

Reviewers: jeff, kevinb
Copy link
Member

@somewhatabstract somewhatabstract left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kevinbarabash kevinbarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@benjaminjkraft
Copy link
Contributor Author

Whoops, I forgot to merge after Jeff approved this and now don't have permissions. Could someone else land it?

@somewhatabstract
Copy link
Member

Whoops, I forgot to merge after Jeff approved this and now don't have permissions. Could someone else land it?

Sure :)

@somewhatabstract somewhatabstract merged commit e0f925c into master Nov 5, 2021
@somewhatabstract somewhatabstract deleted the benkraft.genqlient branch November 5, 2021 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants