Skip to content

Switch to notarytool for notarization #3642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Sep 19, 2023
+125 −217
Merged

Switch to notarytool for notarization #3642

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
047f09e
Migrate to notarytool
DRSchlaubi Jul 7, 2023
a885c72
Update notarytool output processor
DRSchlaubi Jul 17, 2023
9996035
Throw exception lazily in provider
AlexeyTsvetkov Sep 6, 2023
ecee137
Remove unused internal field
AlexeyTsvetkov Sep 7, 2023
2677c5a
Use correct provider
AlexeyTsvetkov Sep 7, 2023
e9f60c2
Set deprecation level to error
AlexeyTsvetkov Sep 7, 2023
f6f32c4
Wait for notarization, then staple package
AlexeyTsvetkov Sep 7, 2023
2f4e694
Update docs
AlexeyTsvetkov Sep 7, 2023
d21b9cc
Rename teamId to teamID for consistency
AlexeyTsvetkov Sep 7, 2023
08de5d1
Reword notarization docs
AlexeyTsvetkov Sep 7, 2023
fea55d5
Fix notarytool args
AlexeyTsvetkov Sep 8, 2023
356161c
Update docs
AlexeyTsvetkov Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update notarytool output processor
  • Loading branch information
@DRSchlaubi @AlexeyTsvetkov
DRSchlaubi authored and AlexeyTsvetkov committed Sep 19, 2023
commit a885c7233a299c3d527e598c2bb8972f79715076
2 changes: 1 addition & 1 deletion ...n/org/jetbrains/compose/desktop/application/tasks/AbstractUploadAppForNotarizationTask.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ abstract class AbstractUploadAppForNotarizationTask @Inject constructor(
}

private fun processUploadToolOutput(packageFile: File, output: String) {
val m = "RequestUUID = ([A-Za-z0-9\\-]+)".toRegex().find(output)
val m = "\\s+id: ([A-Za-z0-9\\-]+)".toRegex().find(output)
?: error("Could not determine RequestUUID from output: $output")

val requestId = m.groupValues[1]
Expand Down