Skip to content

Introduce wasmJsBrowserDistribution task #5375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Jul 31, 2025
Merged

Introduce wasmJsBrowserDistribution task #5375

merged 21 commits into from
Jul 31, 2025

Conversation

Schahen
Copy link
Collaborator

@Schahen Schahen commented Jul 24, 2025 •
edited by igordmn
Loading

Testing

Clone https://github.com/Schahen/ComposeWebApp and run

 ./gradlew  :composeApp: composeCompatibilityBrowserDistribution

Release Notes

Features - Web

  • Introduce composeCompatibilityBrowserDistribution task. This task combines two prod distributions - for js and for wasm in such way so that if modern required features are not supported by the consumer browser, application switch to js mode.

@Schahen Schahen requested review from eymar and terrakok July 24, 2025 08:20
@igordmn
Copy link
Collaborator

igordmn commented Jul 24, 2025 •
edited
Loading

Just in case, if it is not already planned, please, fix the PR description before merging (better also before review, if not agreed beforehand):

  • Describe the changes
  • Release notes should describe a user-faced change, otherwise it is N/A

eymar
eymar reviewed Jul 24, 2025
View reviewed changes
...lugins/compose/src/main/kotlin/org/jetbrains/compose/web/internal/configureWebApplication.kt Outdated
Comment on lines 71 to 72
val jsTargetModuleName = jsDistTask.outputModuleName
val wasmTargetModuleName = wasmDistTask.outputModuleName
Copy link
Member

@eymar eymar Jul 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do both outputModuleName have some default value when a user doesn't explicitly specify it in the DSL?

When would this be false?

onlyIf {
            jsTargetModuleName != null && wasmTargetModuleName != null
        }

eymar
eymar reviewed Jul 24, 2025
View reviewed changes
...lugins/compose/src/main/kotlin/org/jetbrains/compose/web/internal/configureWebApplication.kt Outdated
}
}

private fun Project.introduceComposeWebCompatibilityTask(targets: Collection<KotlinJsIrTarget>) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some gradle plugin tests in the project.

Would you like to add some tests?
For example:

  • a task is created when the condition match and it's not created otherwise
  • Run the task and check the output directory exists. And the output directory contains the must-have files (index.html, .js file, wasm file, etc)

eymar