Introduce wasmJsBrowserDistribution task #5375
Conversation
...lugins/compose/src/main/kotlin/org/jetbrains/compose/web/internal/configureWebApplication.kt
Outdated
Show resolved
Hide resolved
...lugins/compose/src/main/kotlin/org/jetbrains/compose/web/internal/configureWebApplication.kt
Outdated
Show resolved
Hide resolved
|
Just in case, if it is not already planned, please, fix the PR description before merging (better also before review, if not agreed beforehand):
|
Unfortunately, without contracts onlyIf is not enough
| val jsTargetModuleName = jsDistTask.outputModuleName | ||
| val wasmTargetModuleName = wasmDistTask.outputModuleName |
There was a problem hiding this comment.
Do both outputModuleName have some default value when a user doesn't explicitly specify it in the DSL?
When would this be false?
onlyIf {
jsTargetModuleName != null && wasmTargetModuleName != null
}
| } | ||
| } | ||
|
|
||
| private fun Project.introduceComposeWebCompatibilityTask(targets: Collection<KotlinJsIrTarget>) { |
There was a problem hiding this comment.
There are some gradle plugin tests in the project.
Would you like to add some tests?
For example:
- a task is created when the condition match and it's not created otherwise
- Run the task and check the output directory exists. And the output directory contains the must-have files (index.html, .js file, wasm file, etc)
...ins/compose/src/test/kotlin/org/jetbrains/compose/test/tests/integration/GradlePluginTest.kt
Outdated
Show resolved
Hide resolved
...ins/compose/src/test/kotlin/org/jetbrains/compose/test/tests/integration/GradlePluginTest.kt
Outdated
Show resolved
Hide resolved
...lugins/compose/src/main/kotlin/org/jetbrains/compose/web/internal/configureWebApplication.kt
Outdated
Show resolved
Hide resolved
...lugins/compose/src/main/kotlin/org/jetbrains/compose/web/internal/configureWebApplication.kt
Outdated
Show resolved
Hide resolved
...lugins/compose/src/main/kotlin/org/jetbrains/compose/web/internal/configureWebApplication.kt
Outdated
Show resolved
Hide resolved
gradle-plugins/compose/src/main/kotlin/org/jetbrains/compose/web/tasks/WebCompatibilityTask.kt
Outdated
Show resolved
Hide resolved
gradle-plugins/compose/src/main/kotlin/org/jetbrains/compose/web/tasks/WebCompatibilityTask.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Oleksandr Karpovich <[email protected]>
gradle-plugins/compose/src/main/kotlin/org/jetbrains/compose/web/tasks/WebCompatibilityTask.kt
Outdated
Show resolved
Hide resolved
| wasmDistFiles = tasks.named("wasmJsBrowserDistribution").get().outputs.files | ||
| } | ||
|
|
||
| internal fun Project.configureWebCompatibility() { |
There was a problem hiding this comment.
let's add a description what's going here
...ins/compose/src/test/kotlin/org/jetbrains/compose/test/tests/integration/GradlePluginTest.kt
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| kotlin { | ||
| js(IR) { |
There was a problem hiding this comment.
As I know, we already don't need IR here
|
|
||
| kotlin { | ||
| js(IR) { | ||
| outputModuleName.set("composeApp") |
There was a problem hiding this comment.
If we want to test a custom name here, then you need a different name, because "composeApp" is a name of the module already
|
|
||
| @OptIn(ExperimentalWasmDsl::class) | ||
| wasmJs { | ||
| outputModuleName.set("composeApp") |
There was a problem hiding this comment.
what will happen if there is a different name?
...ins/compose/src/test/kotlin/org/jetbrains/compose/test/tests/integration/GradlePluginTest.kt
Outdated
Show resolved
Hide resolved
Testing
Clone https://github.com/Schahen/ComposeWebApp and run
Release Notes
Features - Web
composeCompatibilityBrowserDistributiontask. This task combines two prod distributions - for js and for wasm in such way so that if modern required features are not supported by the consumer browser, application switch to js mode.