CfW Fix Composite text input #2256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix text selection + backspace api dump add a comment Adding tests refactoring + tests fixed fix selected text editing improve refactor: collect all events in a list and process them together click on accent using mouse consider key "Process" evt.timeStamp is 0 on iOS browser fix nonTyped events delivery to Compose safari ok too? delete backwards count IME input in FF work IME input in Chrome work accents work
cfd0de6 to
eb051ad
Compare
Schahen
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a different approach to handling the key and input events.
Due to the differences in the browser behavoiur (events order, key values, timestamps), we collect the events and process them together in window.reqiestAnimationFrame callback. It allows to have more info at one point, which simplifies the processing - the decision making is less scattered through the code.
Fixes https://youtrack.jetbrains.com/issue/CMP-8416
Testing
This should be tested by QA
Release Notes
Fixes - Web