Skip to content

Support text context menus in web targets #2207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 3, 2025
Merged

Support text context menus in web targets #2207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17adf4a
Add ContextMenuArea implementation to the skiko source set.
terrakok Jun 30, 2025
264c651
Add ContextMenuToolbar for web targets
terrakok Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions compose/foundation/foundation/api/desktop/foundation.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,6 +378,13 @@ public final class androidx/compose/foundation/content/TransferableContent$Sourc
public final fun getKeyboard-kB6V9T0 ()I
}

public final class androidx/compose/foundation/contextmenu/ComposableSingletons$ContextMenuUi_skikoKt {
public static final field INSTANCE Landroidx/compose/foundation/contextmenu/ComposableSingletons$ContextMenuUi_skikoKt;
public fun <init> ()V
public final fun getLambda$-1846138604$foundation ()Lkotlin/jvm/functions/Function3;
public final fun getLambda$-417510039$foundation ()Lkotlin/jvm/functions/Function8;
}

public final class androidx/compose/foundation/draganddrop/DragAndDropSourceKt {
public static final fun dragAndDropSource (Landroidx/compose/ui/Modifier;Lkotlin/jvm/functions/Function1;)Landroidx/compose/ui/Modifier;
public static final fun dragAndDropSource (Landroidx/compose/ui/Modifier;Lkotlin/jvm/functions/Function1;Lkotlin/jvm/functions/Function1;)Landroidx/compose/ui/Modifier;
Expand Down
22 changes: 22 additions & 0 deletions compose/foundation/foundation/api/foundation.klib.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1472,7 +1472,14 @@ final val androidx.compose.foundation.content/androidx_compose_foundation_conten
final val androidx.compose.foundation.content/androidx_compose_foundation_content_ReceiveContentElement$stableprop // androidx.compose.foundation.content/androidx_compose_foundation_content_ReceiveContentElement$stableprop|#static{}androidx_compose_foundation_content_ReceiveContentElement$stableprop[0]
final val androidx.compose.foundation.content/androidx_compose_foundation_content_ReceiveContentNode$stableprop // androidx.compose.foundation.content/androidx_compose_foundation_content_ReceiveContentNode$stableprop|#static{}androidx_compose_foundation_content_ReceiveContentNode$stableprop[0]
final val androidx.compose.foundation.content/androidx_compose_foundation_content_TransferableContent$stableprop // androidx.compose.foundation.content/androidx_compose_foundation_content_TransferableContent$stableprop|#static{}androidx_compose_foundation_content_TransferableContent$stableprop[0]
final val androidx.compose.foundation.contextmenu/androidx_compose_foundation_contextmenu_ContextMenuColors$stableprop // androidx.compose.foundation.contextmenu/androidx_compose_foundation_contextmenu_ContextMenuColors$stableprop|#static{}androidx_compose_foundation_contextmenu_ContextMenuColors$stableprop[0]
final val androidx.compose.foundation.contextmenu/androidx_compose_foundation_contextmenu_ContextMenuPopupPositionProvider$stableprop // androidx.compose.foundation.contextmenu/androidx_compose_foundation_contextmenu_ContextMenuPopupPositionProvider$stableprop|#static{}androidx_compose_foundation_contextmenu_ContextMenuPopupPositionProvider$stableprop[0]
final val androidx.compose.foundation.contextmenu/androidx_compose_foundation_contextmenu_ContextMenuScope$stableprop // androidx.compose.foundation.contextmenu/androidx_compose_foundation_contextmenu_ContextMenuScope$stableprop|#static{}androidx_compose_foundation_contextmenu_ContextMenuScope$stableprop[0]
final val androidx.compose.foundation.contextmenu/androidx_compose_foundation_contextmenu_ContextMenuSpec$stableprop // androidx.compose.foundation.contextmenu/androidx_compose_foundation_contextmenu_ContextMenuSpec$stableprop|#static{}androidx_compose_foundation_contextmenu_ContextMenuSpec$stableprop[0]
final val androidx.compose.foundation.contextmenu/androidx_compose_foundation_contextmenu_ContextMenuState$stableprop // androidx.compose.foundation.contextmenu/androidx_compose_foundation_contextmenu_ContextMenuState$stableprop|#static{}androidx_compose_foundation_contextmenu_ContextMenuState$stableprop[0]
final val androidx.compose.foundation.contextmenu/androidx_compose_foundation_contextmenu_ContextMenuState_Status$stableprop // androidx.compose.foundation.contextmenu/androidx_compose_foundation_contextmenu_ContextMenuState_Status$stableprop|#static{}androidx_compose_foundation_contextmenu_ContextMenuState_Status$stableprop[0]
final val androidx.compose.foundation.contextmenu/androidx_compose_foundation_contextmenu_ContextMenuState_Status_Closed$stableprop // androidx.compose.foundation.contextmenu/androidx_compose_foundation_contextmenu_ContextMenuState_Status_Closed$stableprop|#static{}androidx_compose_foundation_contextmenu_ContextMenuState_Status_Closed$stableprop[0]
final val androidx.compose.foundation.contextmenu/androidx_compose_foundation_contextmenu_ContextMenuState_Status_Open$stableprop // androidx.compose.foundation.contextmenu/androidx_compose_foundation_contextmenu_ContextMenuState_Status_Open$stableprop|#static{}androidx_compose_foundation_contextmenu_ContextMenuState_Status_Open$stableprop[0]
final val androidx.compose.foundation.draganddrop/androidx_compose_foundation_draganddrop_CacheDrawScopeDragShadowCallback$stableprop // androidx.compose.foundation.draganddrop/androidx_compose_foundation_draganddrop_CacheDrawScopeDragShadowCallback$stableprop|#static{}androidx_compose_foundation_draganddrop_CacheDrawScopeDragShadowCallback$stableprop[0]
final val androidx.compose.foundation.draganddrop/androidx_compose_foundation_draganddrop_DragAndDropSourceDefaults$stableprop // androidx.compose.foundation.draganddrop/androidx_compose_foundation_draganddrop_DragAndDropSourceDefaults$stableprop|#static{}androidx_compose_foundation_draganddrop_DragAndDropSourceDefaults$stableprop[0]
final val androidx.compose.foundation.draganddrop/androidx_compose_foundation_draganddrop_DragAndDropSourceNode$stableprop // androidx.compose.foundation.draganddrop/androidx_compose_foundation_draganddrop_DragAndDropSourceNode$stableprop|#static{}androidx_compose_foundation_draganddrop_DragAndDropSourceNode$stableprop[0]
Expand Down Expand Up @@ -1736,6 +1743,7 @@ final val androidx.compose.foundation.text/androidx_compose_foundation_text_Text
final val androidx.compose.foundation.text/androidx_compose_foundation_text_TextRangeLayoutMeasureResult$stableprop // androidx.compose.foundation.text/androidx_compose_foundation_text_TextRangeLayoutMeasureResult$stableprop|#static{}androidx_compose_foundation_text_TextRangeLayoutMeasureResult$stableprop[0]
final val androidx.compose.foundation.text/androidx_compose_foundation_text_TextRangeLayoutMeasureScope$stableprop // androidx.compose.foundation.text/androidx_compose_foundation_text_TextRangeLayoutMeasureScope$stableprop|#static{}androidx_compose_foundation_text_TextRangeLayoutMeasureScope$stableprop[0]
final val androidx.compose.foundation.text/androidx_compose_foundation_text_TextRangeLayoutModifier$stableprop // androidx.compose.foundation.text/androidx_compose_foundation_text_TextRangeLayoutModifier$stableprop|#static{}androidx_compose_foundation_text_TextRangeLayoutModifier$stableprop[0]
final val androidx.compose.foundation.text/androidx_compose_foundation_text_Translations$stableprop // androidx.compose.foundation.text/androidx_compose_foundation_text_Translations$stableprop|#static{}androidx_compose_foundation_text_Translations$stableprop[0]
final val androidx.compose.foundation.text/androidx_compose_foundation_text_UndoManager$stableprop // androidx.compose.foundation.text/androidx_compose_foundation_text_UndoManager$stableprop|#static{}androidx_compose_foundation_text_UndoManager$stableprop[0]
final val androidx.compose.foundation.text/androidx_compose_foundation_text_defaultSkikoKeyMapping$stableprop // androidx.compose.foundation.text/androidx_compose_foundation_text_defaultSkikoKeyMapping$stableprop|#static{}androidx_compose_foundation_text_defaultSkikoKeyMapping$stableprop[0]
final val androidx.compose.foundation.text/isTypedEvent // androidx.compose.foundation.text/isTypedEvent|@androidx.compose.ui.input.key.KeyEvent{}isTypedEvent[0]
Expand Down Expand Up @@ -1871,7 +1879,14 @@ final fun androidx.compose.foundation.content/androidx_compose_foundation_conten
final fun androidx.compose.foundation.content/androidx_compose_foundation_content_ReceiveContentElement$stableprop_getter(): kotlin/Int // androidx.compose.foundation.content/androidx_compose_foundation_content_ReceiveContentElement$stableprop_getter|androidx_compose_foundation_content_ReceiveContentElement$stableprop_getter(){}[0]
final fun androidx.compose.foundation.content/androidx_compose_foundation_content_ReceiveContentNode$stableprop_getter(): kotlin/Int // androidx.compose.foundation.content/androidx_compose_foundation_content_ReceiveContentNode$stableprop_getter|androidx_compose_foundation_content_ReceiveContentNode$stableprop_getter(){}[0]
final fun androidx.compose.foundation.content/androidx_compose_foundation_content_TransferableContent$stableprop_getter(): kotlin/Int // androidx.compose.foundation.content/androidx_compose_foundation_content_TransferableContent$stableprop_getter|androidx_compose_foundation_content_TransferableContent$stableprop_getter(){}[0]
final fun androidx.compose.foundation.contextmenu/androidx_compose_foundation_contextmenu_ContextMenuColors$stableprop_getter(): kotlin/Int // androidx.compose.foundation.contextmenu/androidx_compose_foundation_contextmenu_ContextMenuColors$stableprop_getter|androidx_compose_foundation_contextmenu_ContextMenuColors$stableprop_getter(){}[0]
final fun androidx.compose.foundation.contextmenu/androidx_compose_foundation_contextmenu_ContextMenuPopupPositionProvider$stableprop_getter(): kotlin/Int // androidx.compose.foundation.contextmenu/androidx_compose_foundation_contextmenu_ContextMenuPopupPositionProvider$stableprop_getter|androidx_compose_foundation_contextmenu_ContextMenuPopupPositionProvider$stableprop_getter(){}[0]
final fun androidx.compose.foundation.contextmenu/androidx_compose_foundation_contextmenu_ContextMenuScope$stableprop_getter(): kotlin/Int // androidx.compose.foundation.contextmenu/androidx_compose_foundation_contextmenu_ContextMenuScope$stableprop_getter|androidx_compose_foundation_contextmenu_ContextMenuScope$stableprop_getter(){}[0]
final fun androidx.compose.foundation.contextmenu/androidx_compose_foundation_contextmenu_ContextMenuSpec$stableprop_getter(): kotlin/Int // androidx.compose.foundation.contextmenu/androidx_compose_foundation_contextmenu_ContextMenuSpec$stableprop_getter|androidx_compose_foundation_contextmenu_ContextMenuSpec$stableprop_getter(){}[0]
final fun androidx.compose.foundation.contextmenu/androidx_compose_foundation_contextmenu_ContextMenuState$stableprop_getter(): kotlin/Int // androidx.compose.foundation.contextmenu/androidx_compose_foundation_contextmenu_ContextMenuState$stableprop_getter|androidx_compose_foundation_contextmenu_ContextMenuState$stableprop_getter(){}[0]
final fun androidx.compose.foundation.contextmenu/androidx_compose_foundation_contextmenu_ContextMenuState_Status$stableprop_getter(): kotlin/Int // androidx.compose.foundation.contextmenu/androidx_compose_foundation_contextmenu_ContextMenuState_Status$stableprop_getter|androidx_compose_foundation_contextmenu_ContextMenuState_Status$stableprop_getter(){}[0]
final fun androidx.compose.foundation.contextmenu/androidx_compose_foundation_contextmenu_ContextMenuState_Status_Closed$stableprop_getter(): kotlin/Int // androidx.compose.foundation.contextmenu/androidx_compose_foundation_contextmenu_ContextMenuState_Status_Closed$stableprop_getter|androidx_compose_foundation_contextmenu_ContextMenuState_Status_Closed$stableprop_getter(){}[0]
final fun androidx.compose.foundation.contextmenu/androidx_compose_foundation_contextmenu_ContextMenuState_Status_Open$stableprop_getter(): kotlin/Int // androidx.compose.foundation.contextmenu/androidx_compose_foundation_contextmenu_ContextMenuState_Status_Open$stableprop_getter|androidx_compose_foundation_contextmenu_ContextMenuState_Status_Open$stableprop_getter(){}[0]
final fun androidx.compose.foundation.draganddrop/androidx_compose_foundation_draganddrop_CacheDrawScopeDragShadowCallback$stableprop_getter(): kotlin/Int // androidx.compose.foundation.draganddrop/androidx_compose_foundation_draganddrop_CacheDrawScopeDragShadowCallback$stableprop_getter|androidx_compose_foundation_draganddrop_CacheDrawScopeDragShadowCallback$stableprop_getter(){}[0]
final fun androidx.compose.foundation.draganddrop/androidx_compose_foundation_draganddrop_DragAndDropSourceDefaults$stableprop_getter(): kotlin/Int // androidx.compose.foundation.draganddrop/androidx_compose_foundation_draganddrop_DragAndDropSourceDefaults$stableprop_getter|androidx_compose_foundation_draganddrop_DragAndDropSourceDefaults$stableprop_getter(){}[0]
final fun androidx.compose.foundation.draganddrop/androidx_compose_foundation_draganddrop_DragAndDropSourceNode$stableprop_getter(): kotlin/Int // androidx.compose.foundation.draganddrop/androidx_compose_foundation_draganddrop_DragAndDropSourceNode$stableprop_getter|androidx_compose_foundation_draganddrop_DragAndDropSourceNode$stableprop_getter(){}[0]
Expand Down Expand Up @@ -2222,6 +2237,7 @@ final fun androidx.compose.foundation.text/androidx_compose_foundation_text_Text
final fun androidx.compose.foundation.text/androidx_compose_foundation_text_TextRangeLayoutMeasureResult$stableprop_getter(): kotlin/Int // androidx.compose.foundation.text/androidx_compose_foundation_text_TextRangeLayoutMeasureResult$stableprop_getter|androidx_compose_foundation_text_TextRangeLayoutMeasureResult$stableprop_getter(){}[0]
final fun androidx.compose.foundation.text/androidx_compose_foundation_text_TextRangeLayoutMeasureScope$stableprop_getter(): kotlin/Int // androidx.compose.foundation.text/androidx_compose_foundation_text_TextRangeLayoutMeasureScope$stableprop_getter|androidx_compose_foundation_text_TextRangeLayoutMeasureScope$stableprop_getter(){}[0]
final fun androidx.compose.foundation.text/androidx_compose_foundation_text_TextRangeLayoutModifier$stableprop_getter(): kotlin/Int // androidx.compose.foundation.text/androidx_compose_foundation_text_TextRangeLayoutModifier$stableprop_getter|androidx_compose_foundation_text_TextRangeLayoutModifier$stableprop_getter(){}[0]
final fun androidx.compose.foundation.text/androidx_compose_foundation_text_Translations$stableprop_getter(): kotlin/Int // androidx.compose.foundation.text/androidx_compose_foundation_text_Translations$stableprop_getter|androidx_compose_foundation_text_Translations$stableprop_getter(){}[0]
final fun androidx.compose.foundation.text/androidx_compose_foundation_text_UndoManager$stableprop_getter(): kotlin/Int // androidx.compose.foundation.text/androidx_compose_foundation_text_UndoManager$stableprop_getter|androidx_compose_foundation_text_UndoManager$stableprop_getter(){}[0]
final fun androidx.compose.foundation.text/androidx_compose_foundation_text_defaultSkikoKeyMapping$stableprop_getter(): kotlin/Int // androidx.compose.foundation.text/androidx_compose_foundation_text_defaultSkikoKeyMapping$stableprop_getter|androidx_compose_foundation_text_defaultSkikoKeyMapping$stableprop_getter(){}[0]
final fun androidx.compose.foundation.v2/androidx_compose_foundation_v2_LazyGridScrollbarAdapter$stableprop_getter(): kotlin/Int // androidx.compose.foundation.v2/androidx_compose_foundation_v2_LazyGridScrollbarAdapter$stableprop_getter|androidx_compose_foundation_v2_LazyGridScrollbarAdapter$stableprop_getter(){}[0]
Expand Down Expand Up @@ -2387,3 +2403,9 @@ final fun androidx.compose.foundation/androidx_compose_foundation_PlatformMagnif

// Targets: [ios]
final fun androidx.compose.foundation/androidx_compose_foundation_PlatformMagnifierFactoryIos17Impl_PlatformMagnifierImpl$stableprop_getter(): kotlin/Int // androidx.compose.foundation/androidx_compose_foundation_PlatformMagnifierFactoryIos17Impl_PlatformMagnifierImpl$stableprop_getter|androidx_compose_foundation_PlatformMagnifierFactoryIos17Impl_PlatformMagnifierImpl$stableprop_getter(){}[0]

// Targets: [js, wasmJs]
final val androidx.compose.foundation.text/androidx_compose_foundation_text_WebContextMenuToolbarSpec$stableprop // androidx.compose.foundation.text/androidx_compose_foundation_text_WebContextMenuToolbarSpec$stableprop|#static{}androidx_compose_foundation_text_WebContextMenuToolbarSpec$stableprop[0]

// Targets: [js, wasmJs]
final fun androidx.compose.foundation.text/androidx_compose_foundation_text_WebContextMenuToolbarSpec$stableprop_getter(): kotlin/Int // androidx.compose.foundation.text/androidx_compose_foundation_text_WebContextMenuToolbarSpec$stableprop_getter|androidx_compose_foundation_text_WebContextMenuToolbarSpec$stableprop_getter(){}[0]
34 changes: 34 additions & 0 deletions compose/foundation/foundation/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,3 +254,37 @@ androidx {
description = "Higher level abstractions of the Compose UI primitives. This library is design system agnostic, providing the high-level building blocks for both application and design-system developers"
legacyDisableKotlinStrictApiMode = true
}


// This task updates the translations of the localizable strings for the desktopMain target.
// It obtains them from Android's base repository.
tasks.register("updateTranslations", UpdateTranslationsTask.class) {
group = "localization"
gitRepo = "https://android.googlesource.com/platform/frameworks/base"
repoResDirectories = ["core/res/res"]
targetDirectory = project.file("src/skikoMain/kotlin/androidx/compose/foundation/text/l10n")
targetPackageName = "androidx.compose.foundation.text.l10n"
kotlinStringsPackageName = "androidx.compose.foundation.text"
stringByResourceName = [
"copy": "Copy",
"paste": "Paste",
"cut": "Cut",
"selectAll": "SelectAll",
"autofill": "Autofill"
]
// This is all the locales translated by Compose on Android in the ui module:
// https://github.com/androidx/androidx/tree/androidx-main/compose/ui/ui/src/androidMain/res
// with the exception of
// - b+sr+Latn which doesn't appear to be supported by Java
// - en_XC which has weird invisible LRM characters, and the visible text is the same as for
// en anyway.
locales = [
"en", "af", "am", "ar", "as", "az", "be", "bg", "bn", "bs", "ca", "cs", "da", "de",
"el", "en_AU", "en_CA", "en_GB", "en_IN", "es", "es_US", "et", "eu", "fa",
"fi", "fr", "fr_CA", "gl", "gu", "hi", "hr", "hu", "hy", "in", "is", "it", "iw",
"ja", "ka", "kk", "km", "kn", "ko", "ky", "lo", "lt", "lv", "mk", "ml", "mn", "mr",
"ms", "my", "nb", "ne", "nl", "or", "pa", "pl", "pt", "pt_BR", "pt_PT", "ro", "ru",
"si", "sk", "sl", "sq", "sr", "sv", "sw", "ta", "te", "th", "tl", "tr", "uk", "ur",
"uz", "vi", "zh_CN", "zh_HK", "zh_TW", "zu"
]
}
Loading