Actually ignore semantics nodes marked as invisible for a11y #2204
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually ignore semantics nodes marked as invisible for a11y; not just report them as invisible.
VoiceOver doesn't skip or ignore accessible components that return
isVisible() = false
.This PR completely removes from the semantic tree nodes that are marked with
hideFromAccessibility()
.Slack discussion
Testing
Adjusted the unit test and also tested manually with VoiceOver with
This should be tested by QA
Release Notes
Fixes - Desktop