Skip to content

Conversation

J535D165
Copy link
Owner

@J535D165 J535D165 commented Mar 29, 2019

In this PR, we drop support for Python 2.7. This is in line with our dependencies like Jellyfish, Pandas and Numpy.

Python 2.7 users can rely on recordlinkage version 0.13. From version 0.14 on, we support only Python >=3.5 (in line with Pandas).

@codecov
Copy link

codecov bot commented Mar 29, 2019

Codecov Report

Merging #91 into master will decrease coverage by 0.49%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #91     +/-   ##
========================================
- Coverage    77.2%   76.7%   -0.5%     
========================================
  Files          33      33             
  Lines        2338    2331      -7     
  Branches      376     376             
========================================
- Hits         1805    1788     -17     
- Misses        408     415      +7     
- Partials      125     128      +3
Impacted Files Coverage Δ
recordlinkage/algorithms/string.py 82.74% <ø> (-0.18%) ⬇️
recordlinkage/index.py 93.46% <ø> (-0.05%) ⬇️
recordlinkage/measures.py 89.32% <ø> (-0.11%) ⬇️
recordlinkage/preprocessing/cleaning.py 80.95% <ø> (-5.42%) ⬇️
recordlinkage/datasets/febrl.py 100% <100%> (ø) ⬆️
recordlinkage/datasets/external.py 94.87% <100%> (ø) ⬆️
recordlinkage/base.py 80.42% <100%> (-0.06%) ⬇️
recordlinkage/preprocessing/encoding.py 83.33% <0%> (-11.12%) ⬇️
recordlinkage/config.py 53.01% <0%> (-1.59%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87a5f4a...3a5779f. Read the comment docs.

The changes break the python_requires settings under python 2 because of import errors
@J535D165 J535D165 merged commit cba3992 into master Jul 12, 2019
@J535D165 J535D165 deleted the drop-py2 branch July 12, 2019 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant