Skip to content

Conversation

geraint0923
Copy link
Contributor

REQUIRED: Add a summary of your PR here, typically including why the change is needed and what was changed. Include any design alternatives for discussion purposes.


--- YOUR PR SUMMARY GOES HERE ---


REQUIRED: Fill out the below checklists or remove if irrelevant

  1. If you are opening a PR for Official Notebooks under the notebooks/official folder, follow this mandatory checklist:
  • Use the notebook template as a starting point.
  • Follow the style and grammar rules outlined in the above notebook template.
  • Verify the notebook runs successfully in Colab since the automated tests cannot guarantee this even when it passes.
  • Passes all the required automated checks. You can locally test for formatting and linting with these instructions.
  • You have consulted with a tech writer to see if tech writer review is necessary. If so, the notebook has been reviewed by a tech writer, and they have approved it.
  • This notebook has been added to the CODEOWNERS file under the Official Notebooks section, pointing to the author or the author's team.
  • The Jupyter notebook cleans up any artifacts it has created (datasets, ML models, endpoints, etc) so as not to eat up unnecessary resources.

  1. If you are opening a PR for Community Notebooks under the notebooks/community folder:
  • This notebook has been added to the CODEOWNERS file under the Community Notebooks section, pointing to the author or the author's team.
  • Passes all the required formatting and linting checks. You can locally test with these instructions.

  1. If you are opening a PR for Community Content under the community-content folder:
  • Make sure your main Content Directory Name is descriptive, informative, and includes some of the key products and attributes of your content, so that it is differentiable from other content
  • The main content directory has been added to the CODEOWNERS file under the Community Content section, pointing to the author or the author's team.
  • Passes all the required formatting and linting checks. You can locally test with these instructions.

@geraint0923 geraint0923 requested a review from a team as a code owner August 15, 2023 06:03
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@geraint0923 geraint0923 force-pushed the forecasting_mp branch 3 times, most recently from 2143e0a to 830629e Compare August 15, 2023 06:53
@andrewferlitsch
Copy link
Contributor

CI/CD test failed:
TypeError: get_time_series_dense_encoder_forecasting_pipeline_and_parameters() got an unexpected keyword argument 'time_series_identifier_columns'

@geraint0923
Copy link
Contributor Author

Thanks, this parameter name will be changed to the time_series_identifier_columns in GCPC 2.3.0(soon to be released).

@geraint0923 geraint0923 requested a review from reznitskii August 18, 2023 05:34
@geraint0923 geraint0923 force-pushed the forecasting_mp branch 5 times, most recently from d112743 to 3543d63 Compare August 21, 2023 03:48
@geraint0923 geraint0923 force-pushed the forecasting_mp branch 3 times, most recently from 2115607 to 494f285 Compare August 22, 2023 06:27
@geraint0923 geraint0923 requested a review from reznitskii August 22, 2023 06:28
@geraint0923 geraint0923 force-pushed the forecasting_mp branch 2 times, most recently from 2fb8597 to 4a63718 Compare August 22, 2023 23:24
@andrewferlitsch andrewferlitsch added this pull request to the merge queue Aug 23, 2023
Merged via the queue into GoogleCloudPlatform:main with commit 5c6d4b8 Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants