-
Notifications
You must be signed in to change notification settings - Fork 76
feat: Update Couchdb to use LoggingProcessorMacro
#2039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update Couchdb to use LoggingProcessorMacro
#2039
Conversation
1064f75
to
bedc912
Compare
This aligns the submodule version with master to avoid test diffs showing version changes from 0.130.0 to 0.131.0.
bedc912
to
97ff6c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added one comment.
[notice] 2021-12-02T23:36:42.555157Z nonode@nohost <0.17165.1> a5f585a0d3 localhost:5984 127.0.0.1 otelu PUT /oteld 201 ok 16 | ||
[info] 2022-01-12T16:52:56.998128Z nonode@nohost <0.216.0> -------- Apache CouchDB has started. Time to relax. | ||
[error] 2022-01-12T16:53:03.094488Z nonode@nohost emulator -------- Error in process <0.463.0> with exit value: | ||
{database_does_not_exist,[{mem3_shards,load_shards_from_db,"_users",[{file,"src/mem3_shards.erl"},{line,399}]},{mem3_shards,load_shards_from_disk,1,[{file,"src/mem3_shards.erl"},{line,374}]},{mem3_shards,load_shards_from_disk,2,[{file,"src/mem3_shards.erl"},{line,403}]},{mem3_shards,for_docid,3,[{file,"src/mem3_shards.erl"},{line,96}]},{fabric_doc_open,go,3,[{file,"src/fabric_doc_open.erl"},{line,39}]},{chttpd_auth_cache,ensure_auth_ddoc_exists,2,[{file,"src/chttpd_auth_cache.erl"},{line,198}]},{chttpd_auth_cache,listen_for_changes,1,[{file,"src/chttpd_auth_cache.erl"},{line,145}]}]} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a known bug that fluent-bit doesn't parse correctly the last line of the logs when there is a MultilineRule definition (summary : The processor is still looking for another line of the log and it is not flushed/exported correctly when fluent-bit stops).
Workaround : Please add two or more log sample lines to input.log
so we can verify the multiline-log is being parsed correctly. This is workaround while we fix/address the bug in parallel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I noticed this and discussed with Dylan, I'll update accordingly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
We will address separately the bug with missing last log in fluent-bit transformation tests.
c6005d9
into
GoogleCloudPlatform:master
Co-authored-by: Francisco Valente Castro <[email protected]>
Description
Refactor the Couchdb receiver logging to be sub-agent agnostic.
Note: this is the first receiver converted with multiline rules
Related issue
How has this been tested?
Updated
transformation_test
andconfgenerator_test
, confirmed the output ofoutput_fluentbit.yaml
was unchanged after refactoring the receiver.Checklist: