Skip to content

Conversation

franciscovalentecastro
Copy link
Contributor

Description

Adding tzdata to build containers to avoid failures when otelopscol can't find a Time Zone database causing test failures.

Context :

Related issue

b/435664151

How has this been tested?

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@franciscovalentecastro franciscovalentecastro changed the title [Dockerfile] Add tzdata in build container setup. [Dockerfile] Add tzdata in Ubuntu build container setup. Aug 6, 2025
@quentinmit
Copy link
Member

Is there a separate PR to add it as a dependency in the deb/rpm packages? It's a runtime dependency irrespective of whether we're running any tests (and arguably we should write an integration test to make sure this actually works when a user installs our packages)

@jefferbrecht
Copy link
Member

Is there a separate PR to add it as a dependency in the deb/rpm packages? It's a runtime dependency irrespective of whether we're running any tests (and arguably we should write an integration test to make sure this actually works when a user installs our packages)

Do we have a clear set of guidelines for when we do or don't enforce package dependencies? We don't enforce e.g. the JRE dependency today, but we do enforce rsyslog, so I'm wondering what the guiding principle is here for adding a tzdata dependency. Is it required for OOTB default behavior to work correctly, for instance?

It looks like non-UTC time zone parsing is covered by the TestCustomLogFormat integration test.

@franciscovalentecastro
Copy link
Contributor Author

franciscovalentecastro commented Aug 8, 2025

Re @jefferbrecht @quentinmit, I will merge this PR and we can followup discussion in b/435664151.

@franciscovalentecastro franciscovalentecastro merged commit 28e6dc9 into master Aug 8, 2025
32 of 56 checks passed
@franciscovalentecastro franciscovalentecastro deleted the fcovalente-add-tzdata branch August 8, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants