Update fluent-bit to v4.0.7. #2071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9cf0195 to
8e52693
Compare
|
Current Status - Fluent-bit
|
2f1d985 to
5373e09
Compare
jefferbrecht
reviewed
Oct 1, 2025
Dockerfile.windows
Outdated
| -DFLB_METRICS=On ` | ||
| -DFLB_WASM=Off ` | ||
| -DFLB_WAMRC=Off ` | ||
| -DFLB_KAFKA=OFF ` |
There was a problem hiding this comment.
Does this mean we don't need -DFLB_(IN|OUT)_KAFKA=Off anymore?
Also, nit: OFF -> Off
There was a problem hiding this comment.
Does this mean we don't need -DFLB_(IN|OUT)_KAFKA=Off anymore?
Yes, from the implementation 1 we could remove IN and OUT from this list. I didn't remove them to be overly descriptive. I'll remove them to see how it looks.
# Kafka support (library in general)
if(FLB_KAFKA)
if(FLB_IN_KAFKA OR FLB_OUT_KAFKA)
...
...
Footnotes
jefferbrecht
reviewed
Oct 1, 2025
dockerfiles/compile.go
Outdated
| build-essential cmake bison flex file libsystemd-dev \ | ||
| devscripts cdbs pkg-config openjdk-${OPENJDK_MAJOR_VERSION}-jdk zip`, | ||
| build-essential bison flex file libsystemd-dev \ | ||
| devscripts cdbs pkg-config openjdk-${OPENJDK_MAJOR_VERSION}-jdk zip` + installCMake, |
There was a problem hiding this comment.
Shouldn't we only need installCMake for distros that ship < 3.20.0? Bookworm ships 3.25.1
There was a problem hiding this comment.
Yes, we should only use installCmake when we need to. I conflated all Ubuntu/Debian failures to this reason initially. Removed installCmake. Done!
jefferbrecht
reviewed
Oct 1, 2025
dockerfiles/compile.go
Outdated
| build-essential cmake bison flex file libsystemd-dev tzdata \ | ||
| devscripts cdbs pkg-config openjdk-${OPENJDK_MAJOR_VERSION}-jdk zip`, | ||
| build-essential bison flex file libsystemd-dev tzdata \ | ||
| devscripts cdbs pkg-config openjdk-${OPENJDK_MAJOR_VERSION}-jdk zip` + installCMake, |
There was a problem hiding this comment.
Likewise, Jammy ships CMake 3.22.1
There was a problem hiding this comment.
Done!
jefferbrecht
reviewed
Oct 1, 2025
dockerfiles/compile.go
Outdated
| build-essential cmake bison flex file libsystemd-dev tzdata \ | ||
| devscripts cdbs pkg-config openjdk-${OPENJDK_MAJOR_VERSION}-jdk zip debhelper`, | ||
| build-essential bison flex file libsystemd-dev tzdata \ | ||
| devscripts cdbs pkg-config openjdk-${OPENJDK_MAJOR_VERSION}-jdk zip debhelper` + installCMake, |
There was a problem hiding this comment.
Done!
jefferbrecht
reviewed
Oct 1, 2025
dockerfiles/compile.go
Outdated
| build-essential cmake bison flex file systemd-dev debhelper libsystemd-dev tzdata \ | ||
| devscripts cdbs pkg-config openjdk-${OPENJDK_MAJOR_VERSION}-jdk zip`, | ||
| build-essential bison flex file systemd-dev debhelper libsystemd-dev tzdata \ | ||
| devscripts cdbs pkg-config openjdk-${OPENJDK_MAJOR_VERSION}-jdk zip` + installCMake, |
There was a problem hiding this comment.
Done!
XuechunHou
approved these changes
Oct 3, 2025
|
All tests passed. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade fluent-bit submodule from
v3.1.6tov4.0.7to bring the following bug fixes :Some details about the upgrade :
Dockerfile.windowsto follow : v4.0.7/dockerfiles/Dockerfile.windows.Graceperiod to0sto avoid any unreliable logs to be sent afterExit_On_Eof.submodules/go.modfile to encapsulate any Go code from submodules from the top level module.gcc8) to buildfluent-bit 4.0.7.3.20or higher is required to buildfluent-bit 4.0.7.DFLB_KAFKA=OFFis a newly added flag that disables allkafkalibraries which fail to build and are not needed.Related issue
b/443678958
b/446168784
b/446655640
How has this been tested?
Checklist: