Skip to content

feat: Update Zookeeper to use LoggingProcessorMacro #2044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 29, 2025
Merged

feat: Update Zookeeper to use LoggingProcessorMacro #2044

merged 3 commits into from
Aug 29, 2025

Conversation

Caleb-Hurshman
Copy link
Collaborator

Description

Refactor the Zookeeper receiver logging to be sub-agent agnostic.
Note: uses multiline

Related issue

How has this been tested?

Updated transformation_test and confgenerator_test, confirmed the output of output_fluentbit.yaml was unchanged after refactoring the receiver.

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@Caleb-Hurshman Caleb-Hurshman added the kokoro:force-run Forces kokoro to run integration tests on a CL label Aug 18, 2025
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Aug 18, 2025
@Caleb-Hurshman Caleb-Hurshman force-pushed the feat/zookeeper-otel-logging branch from e3d9139 to 1fbb95a Compare August 25, 2025 17:54
@Caleb-Hurshman Caleb-Hurshman added the kokoro:force-run Forces kokoro to run integration tests on a CL label Aug 25, 2025
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Aug 25, 2025
franciscovalentecastro
franciscovalentecastro requested changes Aug 25, 2025
View reviewed changes
Copy link
Contributor

@franciscovalentecastro franciscovalentecastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment.

@Caleb-Hurshman Caleb-Hurshman force-pushed the feat/zookeeper-otel-logging branch from b4a2b75 to d25a5fe Compare August 26, 2025 14:50
@Caleb-Hurshman Caleb-Hurshman added the kokoro:force-run Forces kokoro to run integration tests on a CL label Aug 26, 2025
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Aug 26, 2025
@franciscovalentecastro franciscovalentecastro force-pushed the feat/zookeeper-otel-logging branch from d25a5fe to 2aec798 Compare August 26, 2025 16:14
@franciscovalentecastro
Copy link
Contributor

Please resolve conflicts in this PR.

@Caleb-Hurshman Caleb-Hurshman force-pushed the feat/zookeeper-otel-logging branch from 3124f69 to e7812df Compare August 27, 2025 17:28
@Caleb-Hurshman Caleb-Hurshman added the kokoro:force-run Forces kokoro to run integration tests on a CL label Aug 27, 2025
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Aug 27, 2025
@franciscovalentecastro franciscovalentecastro added the kokoro:force-run Forces kokoro to run integration tests on a CL label Aug 27, 2025
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Aug 27, 2025
@franciscovalentecastro franciscovalentecastro added the kokoro:force-run Forces kokoro to run integration tests on a CL label Aug 28, 2025
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Aug 28, 2025
@franciscovalentecastro franciscovalentecastro added the kokoro:force-run Forces kokoro to run integration tests on a CL label Aug 28, 2025
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Aug 28, 2025
@franciscovalentecastro franciscovalentecastro added the kokoro:force-run Forces kokoro to run integration tests on a CL label Aug 28, 2025
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Aug 28, 2025
@franciscovalentecastro franciscovalentecastro added the kokoro:force-run Forces kokoro to run integration tests on a CL label Aug 29, 2025
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Aug 29, 2025
@franciscovalentecastro
Copy link
Contributor

All tests passed. Merging.

@franciscovalentecastro franciscovalentecastro merged commit a22e988 into GoogleCloudPlatform:master Aug 29, 2025
56 checks passed
@Caleb-Hurshman Caleb-Hurshman deleted the feat/zookeeper-otel-logging branch September 3, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@franciscovalentecastro franciscovalentecastro franciscovalentecastro approved these changes

Assignees

No one assigned

Labels

review-focus

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Caleb-Hurshman @franciscovalentecastro @stackdriver-instrumentation-release