Skip to content

[transformation_test] Register windows_event_log_v1 for use in transformation tests. #1977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 15, 2025
Merged

[transformation_test] Register windows_event_log_v1 for use in transformation tests. #1977

merged 7 commits into from
Jul 15, 2025

Conversation

franciscovalentecastro
Copy link
Contributor

@franciscovalentecastro franciscovalentecastro commented Jul 15, 2025 •
edited
Loading

Description

Register windows_event_log_v1 for use in transformation tests.

Note : This is an alternative solution to what was attempted in : #1968.

Related issue

b/413410475

How has this been tested?

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@franciscovalentecastro franciscovalentecastro mentioned this pull request Jul 15, 2025
Closed
9 tasks
quentinmit
quentinmit approved these changes Jul 15, 2025
View reviewed changes
transformation_test/transformation_test.go
}

func init() {
confgenerator.LoggingProcessorTypes.RegisterType(func() confgenerator.LoggingProcessor { return &confgenerator.LoggingProcessorWindowsEventLogV1{} })
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment here saying these are transformation-test-only processors?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comment. Done!

@franciscovalentecastro franciscovalentecastro changed the title [transformation_test] Register windows_event_log_otel_processor for use in transformation tests. [transformation_test] Register windows_event_log_v1 for use in transformation tests. Jul 15, 2025
@franciscovalentecastro franciscovalentecastro force-pushed the fcovalente-transform-test-win-event-log branch from 5efb16c to 002fe51 Compare July 15, 2025 21:19
@franciscovalentecastro
Copy link
Contributor Author

Most integration tests passed. Failures in Ops Agent integration test (SLES 15 AArch64) and third party apps integration test (Debian 11 Bullseye x86_64) are flakes and/or unrelated to the changes in this PR. Merging.

@franciscovalentecastro franciscovalentecastro merged commit 5d72871 into master Jul 15, 2025
66 of 68 checks passed
@franciscovalentecastro franciscovalentecastro deleted the fcovalente-transform-test-win-event-log branch July 15, 2025 22:41
Caleb-Hurshman pushed a commit to Caleb-Hurshman/ops-agent that referenced this pull request Jul 16, 2025
@franciscovalentecastro @Caleb-Hurshman
[transformation_test] Register windows_event_log_v1 for use in tran…
9da8937 
…sformation tests. (GoogleCloudPlatform#1977)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@quentinmit quentinmit quentinmit approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@franciscovalentecastro @quentinmit