Deprecate instrumentation scope processor #1960
Conversation
|
failures seem like flakes. Retrying now |
apps/active_directory_ds.go
Outdated
| otel.AddPrefix("workload.googleapis.com"), | ||
| ), | ||
| otel.ModifyInstrumentationScope(r.Type(), "1.0"), | ||
| otel.Transform( |
There was a problem hiding this comment.
Why not just update the implementation of ModifyInstrumentationScope with the new use of the otel.Transform processor ?
IMO this would be helpful in the long run to reduce code duplication, reduce tech debt and the overall maintenance of 3P app receiver implementations. Also, it will identify this processor instance for future readers with purpose of "changing the instrumentation scope".
There was a problem hiding this comment.
cc @ridwanmsharif @avilevy18, I think we discussed this and the idea was deprecating ModifyInstrumentationScope entirely would decrease the surface area of otel.processors, since ModifyInstrumentationScope and Transform are almost identical anyways
There was a problem hiding this comment.
Heads up, ended up changing the strategy to use the existing otel.TransformationMetrics processor instead.
There was a problem hiding this comment.
Sounds good! The new use of the existing otel.TransformationMetrics to set Scope looks good to me.
68af670 to
a5e2d6c
Compare
Description
Deprecate the existing
modifyscopeprocessor within ops-agent and migrate to utilizing the transform processor OTTL for achieving the same functionality.Related issue
N/A
How has this been tested?
Unit Tests & Integration Tests
Checklist: