Creating new .tar.gz file that contains ops-agent-plugin #1871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuechunHou
reviewed
Jan 30, 2025
There was a problem hiding this comment.
A few things I have noticed:
- Please include
google_cloud_ops_agent_engine(the conf generator) binary in the tarball. - Currently the tarfile has the following structure:
tar -tzf google-cloud-ops-agent-plugin_2.54.0.tar.gz
./
./var/
./var/lib/
./var/lib/google-guest-agent/
./var/lib/google-guest-agent/plugins/
./var/lib/google-guest-agent/plugins/ops-agent-plugin_2.54.0/
./var/lib/google-guest-agent/plugins/ops-agent-plugin_2.54.0/libexec/
./var/lib/google-guest-agent/plugins/ops-agent-plugin_2.54.0/libexec/google_cloud_ops_agent_wrapper
./var/lib/google-guest-agent/plugins/ops-agent-plugin_2.54.0/libexec/google_cloud_ops_agent_diagnostics
./var/lib/google-guest-agent/plugins/ops-agent-plugin_2.54.0/plugin
./var/lib/google-guest-agent/plugins/ops-agent-plugin_2.54.0/THIRD_PARTY_LICENSES/
./var/lib/google-guest-agent/plugins/ops-agent-plugin_2.54.0/subagents/
./var/lib/google-guest-agent/plugins/ops-agent-plugin_2.54.0/subagents/opentelemetry-collector/
./var/lib/google-guest-agent/plugins/ops-agent-plugin_2.54.0/subagents/opentelemetry-collector/otelopscol
./var/lib/google-guest-agent/plugins/ops-agent-plugin_2.54.0/subagents/fluent-bit/
./var/lib/google-guest-agent/plugins/ops-agent-plugin_2.54.0/subagents/fluent-bit/bin/
./var/lib/google-guest-agent/plugins/ops-agent-plugin_2.54.0/subagents/fluent-bit/bin/fluent-bit
What I expect is the following:
tar -tzf ops-agent-plugin.tar.gz
THIRD_PARTY_LICENSES/
THIRD_PARTY_LICENSES/text1.txt
libexec/
libexec/google_cloud_ops_agent_engine
libexec/google_cloud_ops_agent_wrapper
libexec/google_cloud_ops_agent_diagnostics
plugin
subagents/
subagents/opentelemetry-collector/
subagents/opentelemetry-collector/otelopscol
subagents/fluent-bit/
subagents/fluent-bit/bin/
subagents/fluent-bit/bin/fluent-bit
libexec, subagents and THIRD_PARTY_LICENSES dirs need to be at the top level, so as the plugin executable.
- THIRD_PARTY_LICENSES should not be an empty directory; otherwise, the tarball will be rejected by UAP. For example, see this demo plugin: https://source.corp.google.com/piper///depot/google3/cloud/cluster/guestplatform/demo_plugin/THIRD_PARTY_LICENSES/.
For now, we can place an empty text file in the directory. However, could you please send a message to the UAP group chat regarding the required license content and format? Eventually we will have to add the real license to the tarball.
jinghan-ma
reviewed
Jan 30, 2025
XuechunHou
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Building and packing the new ops-agent-plugin binary.
Related issue
b/393166773
How has this been tested?
DNA
Checklist: