Skip to content

Conversation

XuechunHou
Copy link
Contributor

Description

Reduced Go binary size by passing -ldflags -s -w during the build process.

Related issue

How has this been tested?

Everything should build and execute as normal. The Ops Agent logic is not changed; all existing tests should pass for the PR.

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@XuechunHou XuechunHou requested a review from braydonk January 23, 2025 21:00
@XuechunHou XuechunHou self-assigned this Jan 23, 2025
Copy link
Contributor

@braydonk braydonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming all integration tests still pass, LGTM

@braydonk braydonk added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jan 23, 2025
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jan 23, 2025
@XuechunHou XuechunHou added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jan 23, 2025
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jan 23, 2025
@XuechunHou XuechunHou merged commit bf9f561 into master Jan 24, 2025
65 of 66 checks passed
@XuechunHou XuechunHou deleted the ida-ldflags branch January 24, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants