Skip to content

Refactor BigQuery samples. #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 17, 2016
Merged

Refactor BigQuery samples. #297

merged 1 commit into from
Aug 17, 2016

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Aug 16, 2016

Fixes the following issues:

  • Subclassing a static utility class unncecessarily.
  • Parsing constants from a JSON file for every test instead of defining
    actual constants.
  • Rename Bigquery to BigQuery.
  • Formatted using google-java-format
    https://github.com/google/google-java-format

@lesv PTAL

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 16, 2016
@tswast tswast force-pushed the tswast-bq-refactor branch from 83ae0ee to 3ad7c70 Compare August 16, 2016 17:45
lesv
lesv reviewed Aug 16, 2016
View reviewed changes
bigquery/src/main/java/com/google/cloud/bigquery/samples/AsyncQuerySample.java
public static void main(final String[] args)
throws IOException, InterruptedException {
public static void main(final String[] args) throws IOException, InterruptedException {
Scanner scanner = new Scanner(System.in);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some reason these aren't command line args, with defaults?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was the way it was in the existing sample, and it didn't bother me as much as some of the other things I fixed. I can look at changing this, too.

@lesv
Copy link
Contributor

lesv commented Aug 16, 2016

LGTM - all comments are optional.

@tswast
Refactor BigQuery samples.
a9451b5 
Fixes the following issues:

- Subclassing a static utility class unncecessarily.
- Parsing constants from a JSON file for every test instead of defining
  actual constants.
- Rename Bigquery to BigQuery.
- Formatted using google-java-format
  https://github.com/google/google-java-format
@tswast tswast force-pushed the tswast-bq-refactor branch from 3ad7c70 to a9451b5 Compare August 16, 2016 23:45
@tswast
Copy link
Contributor Author

tswast commented Aug 16, 2016

@dpebot merge when green

@dpebot
Copy link
Contributor

dpebot commented Aug 16, 2016

Okay! I'll merge when all statuses are green.

@codecov-io
Copy link

codecov-io commented Aug 17, 2016 •
edited
Loading

Current coverage is 45.73% (diff: 78.37%)

Merging #297 into master will increase coverage by 0.32%

@@             master       #297   diff @@
==========================================
  Files            73         73          
  Lines          2167       2178    +11   
  Methods           0          0          
  Messages          0          0          
  Branches        146        146          
==========================================
+ Hits            984        996    +12   
+ Misses         1156       1155     -1   
  Partials         27         27

Powered by Codecov. Last update 1a4a5d7...a9451b5

@lesv
Copy link
Contributor

lesv commented Aug 17, 2016

@tswast Your choice - DPEbot doesn't think this is green.

@tswast
Copy link
Contributor Author

tswast commented Aug 17, 2016

Interesting. The Travis logs look fine to me. Maybe @jonparrott can help track down why it didn't automerge.

@tswast tswast merged commit b54ad45 into master Aug 17, 2016
@tswast tswast deleted the tswast-bq-refactor branch August 17, 2016 18:12
@theacodes
Copy link

It seems github's search indexing isn't quick enough for me to effectively filter the PRs. I'm gonna see if I can't get a fix in this afternoon.

It should work, but every now and then github will be slow about indexing so it'll fail to find the PR.

averikitsch pushed a commit that referenced this pull request Oct 27, 2022
@renovate-bot
chore(deps): update dependency com.google.cloud:libraries-bom to v15 (#…
77298c1 
…297)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [com.google.cloud:libraries-bom](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java) | major | `14.4.1` -> `15.0.0` |

---

### Renovate configuration

:date: **Schedule**: At any time (no schedule defined).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-tasks).
@averikitsch averikitsch mentioned this pull request Oct 27, 2022
Merged
9 tasks
averikitsch pushed a commit that referenced this pull request Nov 1, 2022
@renovate-bot @averikitsch
chore(deps): update dependency com.google.cloud:libraries-bom to v15 (#…
79a59fc