Skip to content

Conversation

samtstern
Copy link
Contributor

@samtstern samtstern commented Jan 11, 2018

No description provided.

Change-Id: Ifa49281ec39d408b45a353da546b57a30da9011f
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 11, 2018
@samtstern
Copy link
Contributor Author

@jabubake can you assign the appropriate reviewer here?

@jabubake jabubake self-requested a review January 11, 2018 20:29
jabubake
jabubake previously approved these changes Jan 11, 2018
Copy link
Contributor

@jabubake jabubake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samtstern
Copy link
Contributor Author

Thanks! What's up with Kokoro?

@jabubake
Copy link
Contributor

@samtstern : not sure. @kurtisvg any clue ?

@lesv lesv added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 11, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 11, 2018
@lesv
Copy link
Contributor

lesv commented Jan 11, 2018

You need to add the tag kokoro:run or kokoro:force-run for fork'd PR's. (so you can inspect the code first before running on Kokoro.

lesv
lesv previously approved these changes Jan 11, 2018
@samtstern
Copy link
Contributor Author

@lesv looks like you and @kokoro-team need to work out your differences haha

@lesv
Copy link
Contributor

lesv commented Jan 11, 2018

@samtstern It's actually a security feature, it lets us accept PR's from anyone, and only run code after we review it. It let's us work on a branch will full features.

@samtstern
Copy link
Contributor Author

@lesv I mean that you added the kokoro:force-run label but it was immediately removed.

@lesv
Copy link
Contributor

lesv commented Jan 11, 2018

Ah, but @samtstern that means it also started the build. It's the way Kokoro works, you set it, it does the action and clears the flag so you can set it again.

@samtstern
Copy link
Contributor Author

@lesv cool thanks for the explanation!

Change-Id: Ia886868d51dcd2a66561845fca6fb52a220b7227
@samtstern samtstern dismissed stale reviews from lesv and jabubake via 9e81e1a January 11, 2018 22:43
@samtstern
Copy link
Contributor Author

@jabubake I fixed test failures could you add the kokoro label?

@kurtisvg kurtisvg added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 11, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 11, 2018
@kurtisvg kurtisvg merged commit f48dea1 into GoogleCloudPlatform:master Jan 11, 2018
minherz pushed a commit that referenced this pull request Nov 9, 2022
…orting to v0.124.12-beta (#988)

* chore(deps): update dependency com.google.cloud:google-cloud-errorreporting to v0.124.12-beta

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
minherz pushed a commit that referenced this pull request Nov 10, 2022
…orting to v0.124.12-beta (#988)

* chore(deps): update dependency com.google.cloud:google-cloud-errorreporting to v0.124.12-beta

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
minherz pushed a commit that referenced this pull request Nov 10, 2022
…orting to v0.124.12-beta (#988)

* chore(deps): update dependency com.google.cloud:google-cloud-errorreporting to v0.124.12-beta

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Shabirmean pushed a commit that referenced this pull request Nov 14, 2022
…#988)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-core](https://togithub.com/googleapis/java-core) | `2.8.9` -> `2.8.10` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.10/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.10/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.10/compatibility-slim/2.8.9)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.10/confidence-slim/2.8.9)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-core</summary>

### [`v2.8.10`](https://togithub.com/googleapis/java-core/blob/HEAD/CHANGELOG.md#&#8203;2810-httpsgithubcomgoogleapisjava-corecomparev289v2810-2022-08-24)

[Compare Source](https://togithub.com/googleapis/java-core/compare/v2.8.9...v2.8.10)

##### Dependencies

-   update dependency com.google.api:gax-bom to v2.19.0 ([#&#8203;907](https://togithub.com/googleapis/java-core/issues/907)) ([51b824c](https://togithub.com/googleapis/java-core/commit/51b824c225fd7095138e1ec2b6d47af4e2a34352))
-   update dependency io.grpc:grpc-bom to v1.49.0 ([#&#8203;908](https://togithub.com/googleapis/java-core/issues/908)) ([fbccd2d](https://togithub.com/googleapis/java-core/commit/fbccd2daceb0984c7cb95f84f89a116e54bf4ddc))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-dialogflow).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNzQuMSIsInVwZGF0ZWRJblZlciI6IjMyLjE3NC4xIn0=-->
Shabirmean pushed a commit that referenced this pull request Nov 15, 2022
…#988)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-core](https://togithub.com/googleapis/java-core) | `2.8.9` -> `2.8.10` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.10/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.10/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.10/compatibility-slim/2.8.9)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.10/confidence-slim/2.8.9)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-core</summary>

### [`v2.8.10`](https://togithub.com/googleapis/java-core/blob/HEAD/CHANGELOG.md#&#8203;2810-httpsgithubcomgoogleapisjava-corecomparev289v2810-2022-08-24)

[Compare Source](https://togithub.com/googleapis/java-core/compare/v2.8.9...v2.8.10)

##### Dependencies

-   update dependency com.google.api:gax-bom to v2.19.0 ([#&#8203;907](https://togithub.com/googleapis/java-core/issues/907)) ([51b824c](https://togithub.com/googleapis/java-core/commit/51b824c225fd7095138e1ec2b6d47af4e2a34352))
-   update dependency io.grpc:grpc-bom to v1.49.0 ([#&#8203;908](https://togithub.com/googleapis/java-core/issues/908)) ([fbccd2d](https://togithub.com/googleapis/java-core/commit/fbccd2daceb0984c7cb95f84f89a116e54bf4ddc))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-dialogflow).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNzQuMSIsInVwZGF0ZWRJblZlciI6IjMyLjE3NC4xIn0=-->
Sita04 pushed a commit that referenced this pull request Feb 7, 2023
🤖 I have created a release *beep* *boop*
---


## [3.7.1](googleapis/java-dlp@v3.7.0...v3.7.1) (2022-09-20)


### Dependencies

* Update dependency com.google.cloud:google-cloud-pubsub to v1.120.16 ([#983](googleapis/java-dlp#983)) ([692695d](googleapis/java-dlp@692695d))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants