Skip to content

Maven Dependency Cleanup - Appengine #969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 38 commits into from
Jan 3, 2018
Merged

Maven Dependency Cleanup - Appengine #969

merged 38 commits into from
Jan 3, 2018

Conversation

kurtisvg
Copy link
Contributor

@kurtisvg kurtisvg commented Dec 21, 2017 •
edited
Loading

This PR cleans up the dependency structure for the Appengine folder. It does the following:

  1. Changes parents for individual projects to our shared-configuration so they users can move a relevant folder without breaking things.
  2. Addresses any exists check-style violations
  3. Adds the Open in Cloud Shell button for all README.md

Additionally, it deletes the appengine/channel samples since the service has been shutdown.

@kurtisvg kurtisvg added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 21, 2017
@kurtisvg kurtisvg requested a review from lesv December 21, 2017 17:57
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 21, 2017
@lesv
Copy link
Contributor

lesv commented Dec 21, 2017

Wow - you just want me unhappy. 241 files?

lesv
lesv reviewed Dec 21, 2017
View reviewed changes
appengine/remote/remote-server/src/main/java/com/example/appengine/remote/RemoteServlet.java
/**
* Copyright 2016 Google Inc.
/*
* Copyright 2015 Google Inc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general (and I saw this earlier), we don't change the dates. (Rolling them forward or backward).

lesv
lesv previously approved these changes Dec 21, 2017
View reviewed changes
Copy link
Contributor

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great - Thanks.

And I figured out how to deal w/ PR's this large, so it's ok to do again.

@lesv
Copy link
Contributor

lesv commented Dec 21, 2017

I presume you meant Open in Cloud Shell, not SQL.

kurtisvg added 23 commits January 3, 2018 08:53
@kurtisvg
Cleaned appengine/analytics.
c964195
@kurtisvg
Cleaned appengeine/appidenity
de70cfd
@kurtisvg
Removed 'channel' samples - (service disabled)
b000023
@kurtisvg
Cleaned up appengine/cloudsql.
b4e80c2
@kurtisvg
Cleaned appengine/datastore.
df2271c
@kurtisvg
Cleaned appengine/endpoints-frameworks-v2/backend
fce720d
@kurtisvg
Cleaned appengine/endpoints-frameworks-v2/guice
32d2a0f
@kurtisvg
Cleaned appengine/endpoints-frameworks-v2/migration-example
a4946b9
@kurtisvg
Cleaned appengine/endpoints-v1-helloworld.
eea2e4e
@kurtisvg
Cleaned firebase-event-proxy.
51ce2f6
@kurtisvg
Updated Appengine/Firebase.
1de5404
@kurtisvg
Cleaned appengine/gaeinfo.
604fbc7
@kurtisvg
Cleaned appengine/guestbook-cloud-datastore.
2f32ee0
@kurtisvg
Cleaned appengine/appengine-guestbook-objectify.
6bff2ab
@kurtisvg
Cleaned appengine/helloworld.
5b095fc
@kurtisvg
Cleaned appengine/helloworld-new-plugins.
173509f
@kurtisvg
Cleaned appengine/iap.
b534793
@kurtisvg
Cleaned appengine/images.
7cd6252
@kurtisvg
Cleaned appengine/logs.
34e7d72
@kurtisvg
Cleaned appengine/mail.
5122905
@kurtisvg
Cleaned appengine/mailgun.
33d67e1
@kurtisvg
Cleaned appengine/mailjet
7eb89fe
@kurtisvg
Cleaned appengine/memchache
7d6bd04
@kurtisvg
Copy link
Contributor Author

kurtisvg commented Jan 3, 2018

Merging - Issue with test is because of Vision Beta.

@kurtisvg kurtisvg merged commit 7f5772f into master Jan 3, 2018
@kurtisvg kurtisvg deleted the mvn-cleanup branch January 3, 2018 18:21
@kurtisvg