feat: Consolidate postgres providers #493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a81435a to
1845874
Compare
Create a common PostgresDatastore class to encapsulate all the DB query logic based on a given connection pool. Reuse the same logic across AlloyDB & CloudSQL postgres providers for better code maintainability and less redundancy.
1845874 to
f49b2ca
Compare
vishwarajanand
approved these changes
Sep 19, 2024
Contributor
vishwarajanand
left a comment
There was a problem hiding this comment.
LGTM, approving to unblock..
I checked the queries moved to postgres_datastore seem similar (and do not miss anything obviously) from the queries deleted.
Collaborator
|
@anubhav756 Let's be careful about enabling automerge when having multiple reviewers |
kurtisvg
reviewed
Sep 19, 2024
| ) | ||
| assert res == expected | ||
| assert sql is None | ||
| assert sql is not None |
Collaborator
There was a problem hiding this comment.
This doesn't seem like a particularly useful check -- we should either remove it or assert the SQL is something expected
| ) -> tuple[list[Any], Optional[str]]: | ||
| async with self.__pool.connect() as conn: | ||
| sql = """ | ||
| SELECT user_name, airline, flight_number, departure_airport, arrival_airport, departure_time, arrival_time FROM tickets |
Collaborator
There was a problem hiding this comment.
nit: this is a pretty long line, consider refactoring it onto multiple lines
anubhav756
pushed a commit
that referenced
this pull request
Dec 3, 2024
🤖 I have created a release *beep* *boop* --- ## [0.3.0](v0.2.0...v0.3.0) (2024-12-03) ### Features * Add similarity threshold to amenity search ([#477](#477)) ([c49bef9](c49bef9)) * Add tracing for AlloyDB and CloudSQL Postgres providers ([#494](#494)) ([2fa03bc](2fa03bc)) * Consolidate postgres providers ([#493](#493)) ([a3b2c42](a3b2c42)) * Reuse connector object across different database connections in… ([#487](#487)) ([61c0f52](61c0f52)) * Switch the llm to ChatVertexAI ([#486](#486)) ([479c5e5](479c5e5)) ### Bug Fixes * Add test cases to improve coverage for postgres and over more tools. ([#508](#508)) ([20870ea](20870ea)) * Reuse connector object across different database connections. ([#484](#484)) ([2b05739](2b05739)), closes [#416](#416) * update close client function to async ([#505](#505)) ([b614276](b614276)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a common
PostgresDatastoreclass to encapsulate all the DB query logic based on a given connection pool. Reuse the same logic across AlloyDB & CloudSQL Postgres providers for better code maintainability and less redundancy.