report: fix category highlight in DevTools #15413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@bfgeek can you run |
Contributor
Author
|
@adamraine - done. |
adamraine
approved these changes
Aug 28, 2023
copybara-service bot
pushed a commit
to ChromeDevTools/devtools-frontend
that referenced
this pull request
Aug 30, 2023
This CL upstreams the following report changes from Github: GoogleChrome/lighthouse#15413 GoogleChrome/lighthouse#15415 Bug: 1476399 Change-Id: Ifb4c2f72adcfd2fb50b4bbd3f9efb3acd63f61be Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4823362 Reviewed-by: Connor Clark <[email protected]> Commit-Queue: Adam Raine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This contains a fix for:
https://bugs.chromium.org/p/chromium/issues/detail?id=1476399
Chromium is changing now static-position works for grid elements - see https://bugs.chromium.org/p/chromium/issues/detail?id=1454831.
Lighthouse was relying on the previous behaviour, this PR will ensure that it'll work with both behaviours.
Related Issues/PRs
https://bugs.chromium.org/p/chromium/issues/detail?id=1476399