Jgriffe/refacto authentication #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salome-voltz
suggested changes
Nov 18, 2024
c6f8f59 to
f72b824
Compare
salome-voltz
approved these changes
Nov 18, 2024
Contributor
salome-voltz
left a comment
There was a problem hiding this comment.
Works for me. I think we should do some qa to have a clear list of the edge cases
4a30605 to
1f50986
Compare
salome-voltz
approved these changes
Nov 19, 2024
1f50986 to
816b609
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
What has been done
Validation
PR check list