Skip to content

refactor: Reduce ERC1155RoyalitySoulboundV1 size #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 23, 2024
Merged

refactor: Reduce ERC1155RoyalitySoulboundV1 size #135

merged 2 commits into from
May 23, 2024

Conversation

@vasinl124
Copy link
Contributor

Issue: resolves

🐵 Description

🙊 Checklist:

  • I have added tests proving my fix is effective or that my feature works
  • Contract deployed to testnet(only for new contracts)

@vasinl124 vasinl124 marked this pull request as ready for review May 22, 2024 20:07
@vasinl124 vasinl124 requested a review from ogarciarevett as a code owner May 22, 2024 20:07
ogarciarevett
ogarciarevett approved these changes May 23, 2024
View reviewed changes
Copy link
Collaborator

@ogarciarevett ogarciarevett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vasinl124 vasinl124 merged commit adf0ef0 into main May 23, 2024
@vasinl124 vasinl124 deleted the feat/reduce-ERC1155RoyalitySoulboundV1-size branch May 23, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ogarciarevett ogarciarevett ogarciarevett approved these changes

@RobertoMSousa RobertoMSousa Awaiting requested review from RobertoMSousa

@karacurt karacurt Awaiting requested review from karacurt karacurt is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vasinl124 @ogarciarevett