Skip to content

reuse achievo soulbound contract and whitelist sig #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 16, 2024
Merged

reuse achievo soulbound contract and whitelist sig #119

merged 6 commits into from
May 16, 2024

Conversation

@vasinl124
Copy link
Contributor

Issue: resolves

🐵 Description

🙊 Checklist:

  • I have added tests proving my fix is effective or that my feature works
  • Contract deployed to testnet(only for new contracts)

@vasinl124 vasinl124 force-pushed the feat/Update-gamesummary-contract branch from 92b8482 to c7fbdeb Compare April 30, 2024 22:11
@openzeppelin-code
Copy link

openzeppelin-code bot commented May 1, 2024 •
edited
Loading

reuse achievo soulbound contract and whitelist sig

Generated at commit: 60e7402e1e10cb3fbbda3e012b60bdb2009d8061

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 2
2
0
9
39
52
Dependencies Critical
High
Medium
Low
Note
Total		 1
0
0
0
214
215

For more details view the full report in OpenZeppelin Code Inspector

@vasinl124 vasinl124 marked this pull request as ready for review May 1, 2024 20:34
@vasinl124 vasinl124 requested a review from ogarciarevett as a code owner May 1, 2024 20:34
@vasinl124
Copy link
Contributor Author

https://explorer.sepolia.mantle.xyz/address/0xeEa8eF1f9458c8b246c8704B6f2B63491d3D73d9

gotta wait for Daniel PR merge so I can upload the deployed contract to DB @ogarciarevett

ogarciarevett
ogarciarevett approved these changes May 1, 2024
View reviewed changes
Copy link
Collaborator

@ogarciarevett ogarciarevett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, GJ mate

@vasinl124 vasinl124 force-pushed the feat/Update-gamesummary-contract branch from 69646b8 to 4b17514 Compare May 2, 2024 15:05
@vasinl124 vasinl124 force-pushed the feat/Update-gamesummary-contract branch 2 times, most recently from 9524683 to 162e9da Compare May 3, 2024 19:04
@vasinl124 vasinl124 force-pushed the feat/Update-gamesummary-contract branch from 162e9da to 522b0d5 Compare May 6, 2024 17:37
@vasinl124 vasinl124 marked this pull request as draft May 6, 2024 17:37
@vasinl124 vasinl124 marked this pull request as ready for review May 15, 2024 19:25
@vasinl124 vasinl124 force-pushed the feat/Update-gamesummary-contract branch from 5ab4bc6 to 60e7402 Compare May 15, 2024 19:27
@vasinl124 vasinl124 requested a review from ogarciarevett May 15, 2024 19:28
@vasinl124 vasinl124 merged commit 247ffd6 into main May 16, 2024
@vasinl124 vasinl124 deleted the feat/Update-gamesummary-contract branch May 16, 2024 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ogarciarevett ogarciarevett Awaiting requested review from ogarciarevett ogarciarevett is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vasinl124 @ogarciarevett